Opened 7 years ago

Closed 5 years ago

Last modified 5 years ago

#6751 closed defect (fixed)

libavformat/mpegtsenc.c:1646: bad if statement ?

Reported by: dcb Owned by:
Priority: normal Component: avformat
Version: unspecified Keywords:
Cc: Blocked By:
Blocking: Reproduced by developer: no
Analyzed by developer: no

Description (last modified by Carl Eugen Hoyos)

ffmpeg-3.4/libavformat/mpegtsenc.c:1646]: (warning) Logical conjunction always evaluates to false: EXPR < 32 && EXPR >= 48.

Source code is

       if ((state & 0x7e) < 2*16 && (state & 0x7e) >= 2*24)

maybe better code

       if ((state & 0x7e) < 2*16 || (state & 0x7e) >= 2*24)

Change History (3)

comment:1 by Balling, 5 years ago

Resolution: → duplicate
Status: new → closed

Merged in #8156

Last edited 5 years ago by Balling (previous) (diff)

comment:2 by Carl Eugen Hoyos, 5 years ago

Description: modified (diff)
Resolution: duplicate
Status: closed → reopened

comment:3 by Jun Zhao, 5 years ago

Resolution: → fixed
Status: reopened → closed

Closed, fixed by commit: ​https://github.com/FFmpeg/FFmpeg/commit/8f7a043609554fd5e6917afeaed5d95bca420859

Version 0, edited 5 years ago by Jun Zhao (next)
Note: See TracTickets for help on using tickets.