Opened 7 years ago

Closed 6 years ago

Last modified 6 years ago

#6752 closed defect (fixed)

ffmpeg-3.4/libavformat/hlsenc.c:210: bad if statement ?

Reported by: dcb Owned by:
Priority: normal Component: avformat
Version: git-master Keywords: hls
Cc: Blocked By:
Blocking: Reproduced by developer: no
Analyzed by developer: no

Description (last modified by Carl Eugen Hoyos)

ffmpeg-3.4/libavformat/hlsenc.c:210]: (warning) Logical disjunction always evaluates to true: EXPR != '/' || EXPR != '\\'.

Source code is

    if ((*(pos - 1) != '/') || (*(pos - 1) != '\\')) {

Maybe better code

    if ((*(pos - 1) != '/') && (*(pos - 1) != '\\')) {

Change History (2)

comment:1 by Carl Eugen Hoyos, 6 years ago

Description: modified (diff)
Keywords: hls added
Resolution: → fixed
Status: new → closed
Version: unspecified → git-master

Fixed by Steven Liu in bb660800a55f5171f77316941afe2e62534ee72c

comment:2 by Carl Eugen Hoyos, 6 years ago

Description: modified (diff)
Note: See TracTickets for help on using tickets.