Opened 2 years ago

Closed 4 months ago

Last modified 4 months ago

#6751 closed defect (fixed)

libavformat/mpegtsenc.c:1646: bad if statement ?

Reported by: dcb Owned by:
Priority: normal Component: avformat
Version: unspecified Keywords:
Cc: Blocked By:
Blocking: Reproduced by developer: no
Analyzed by developer: no

Description (last modified by cehoyos)

ffmpeg-3.4/libavformat/mpegtsenc.c:1646]: (warning) Logical conjunction always evaluates to false: EXPR < 32 && EXPR >= 48.

Source code is

       if ((state & 0x7e) < 2*16 && (state & 0x7e) >= 2*24)

maybe better code

       if ((state & 0x7e) < 2*16 || (state & 0x7e) >= 2*24)

Change History (3)

comment:1 Changed 4 months ago by Balling

  • Resolution set to duplicate
  • Status changed from new to closed

Merged in #8156

Last edited 4 months ago by Balling (previous) (diff)

comment:2 Changed 4 months ago by cehoyos

  • Description modified (diff)
  • Resolution duplicate deleted
  • Status changed from closed to reopened

comment:3 Changed 4 months ago by mypopy

  • Resolution set to fixed
  • Status changed from reopened to closed

Closed, fixed by commit: 8f7a043609554fd5e6917afeaed5d95bca420859

Last edited 4 months ago by cehoyos (previous) (diff)
Note: See TracTickets for help on using tickets.