ffmpeg-3.4/libavformat/mxfdec.c:2340]: (style) Suspicious condition

[dcb]

ffmpeg-3.4/libavformat/mxfdec.c:2340]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses.

Source code is

SET_TS_METADATA(pb, "modification_date", ts, str);

but

#define SET_TS_METADATA(pb, name, var, str) do { \

var = avio_rb64(pb); \
if ((ret = avpriv_dict_set_timestamp(&s->metadata, name, mxf_timestamp_to_int64(var)) < 0)) \

return ret; \

} while (0)

maybe better code

#define SET_TS_METADATA(pb, name, var, str) do { \

var = avio_rb64(pb); \
if ((ret = avpriv_dict_set_timestamp(&s->metadata, name, mxf_timestamp_to_int64(var))) < 0) \

return ret; \

} while (0)

[Elon Musk]

Fixed in e5a0013c4a6248fe7e2a651db1fda6b9bb2cd743.