Opened 4 years ago

Closed 3 years ago

Last modified 3 years ago

#6750 closed defect (fixed)

ffmpeg-3.4/libavformat/mxfdec.c:2340]: (style) Suspicious condition

Reported by: dcb Owned by:
Priority: normal Component: avformat
Version: git-master Keywords: mxf
Cc: Blocked By:
Blocking: Reproduced by developer: no
Analyzed by developer: no

Description

ffmpeg-3.4/libavformat/mxfdec.c:2340]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses.

Source code is

SET_TS_METADATA(pb, "modification_date", ts, str);

but

#define SET_TS_METADATA(pb, name, var, str) do { \

var = avio_rb64(pb); \
if ((ret = avpriv_dict_set_timestamp(&s->metadata, name, mxf_timestamp_to_int64(var)) < 0)) \

return ret; \

} while (0)

maybe better code

#define SET_TS_METADATA(pb, name, var, str) do { \

var = avio_rb64(pb); \
if ((ret = avpriv_dict_set_timestamp(&s->metadata, name, mxf_timestamp_to_int64(var))) < 0) \

return ret; \

} while (0)

Change History (2)

comment:1 by Elon Musk, 3 years ago

Resolution: fixed
Status: newclosed

comment:2 by Carl Eugen Hoyos, 3 years ago

Keywords: mxf added
Version: unspecifiedgit-master
Note: See TracTickets for help on using tickets.