Opened 6 years ago
Closed 5 years ago
#6749 closed defect (invalid)
ffmpeg-3.4/libavcodec/eatqi.c:115: suspicious assignment ?
|Reported by:||dcb||Owned by:|
|Blocking:||Reproduced by developer:||no|
|Analyzed by developer:||no|
ffmpeg-3.4/libavcodec/eatqi.c:115]: (style) int result is assigned to long variable.
Source code is
const int64_t qscale = (215 - 2*quant)*5;
maybe better code
const int64_t qscale = (215L - 2*quant)*5;
Change History (4)
comment:1 by , 6 years ago
comment:2 by , 6 years ago
So would it be a good idea to make qscale into an int ?
comment:3 by , 6 years ago
Its fine the way it is.
comment:4 by , 5 years ago
|Component:||avcodec → undetermined|
|Status:||new → closed|
Note: See TracTickets for help on using tickets.
What difference would it make? quant is not large.