Opened 4 years ago

Closed 3 years ago

#6749 closed defect (invalid)

ffmpeg-3.4/libavcodec/eatqi.c:115: suspicious assignment ?

Reported by: dcb Owned by:
Priority: normal Component: undetermined
Version: unspecified Keywords:
Cc: Blocked By:
Blocking: Reproduced by developer: no
Analyzed by developer: no

Description

ffmpeg-3.4/libavcodec/eatqi.c:115]: (style) int result is assigned to long variable.

Source code is

const int64_t qscale = (215 - 2*quant)*5;

maybe better code

const int64_t qscale = (215L - 2*quant)*5;

Change History (4)

comment:1 by jkqxz, 4 years ago

What difference would it make? quant is not large.

comment:2 by dcb, 4 years ago

So would it be a good idea to make qscale into an int ?

comment:3 by Hendrik, 4 years ago

Its fine the way it is.

comment:4 by Carl Eugen Hoyos, 3 years ago

Component: avcodecundetermined
Resolution: invalid
Status: newclosed
Note: See TracTickets for help on using tickets.