#9355 closed defect (fixed)
Fix for PES packets with too much padding
Reported by: | Sergio Ammirata, Ph.D. | Owned by: | |
---|---|---|---|
Priority: | normal | Component: | undetermined |
Version: | unspecified | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Reproduced by developer: | no | |
Analyzed by developer: | no |
Description
Summary of the bug:
PES packet with too much padding trigger unlimited error messages "PES packet size mismatch" because the code that corrects the length is wrong.
Here is a sample file: http://99.93.62.129/smpte2038.ts
PID 300 is the one triggering the errors.
I am attaching a patch that fixes the problem.
Attachments (1)
Change History (11)
by , 3 years ago
Attachment: | 0001-Fix-setting-the-correct-size-for-PES-packets-with-to.patch added |
---|
follow-ups: 3 6 comment:2 by , 3 years ago
comment:3 by , 3 years ago
Replying to Sergio Ammirata, Ph.D.:
Replying to Balling:
What is #2392? That one has nothing to do with above.
I do not know what #2392 is ... that comment was there from before.
Yet that comment should be deleted after your change or better clarified. Also, there are other bugs that often have this PES warning, maybe they should be checked too.
comment:4 by , 3 years ago
comment:5 by , 3 years ago
Status: | new → open |
---|
Also this is a duplicate of #5860. P.S. Apparently not.
comment:6 by , 3 years ago
Replying to Sergio Ammirata, Ph.D.:
Replying to Balling:
What is #2392? That one has nothing to do with above.
I do not know what #2392 is ... that comment was there from before.
I found it! It is this issue, https://ffmpeg-issues.lscube.narkive.com/s0jecfqy/issue2392-memory-leak-in-mpegts-demuxer-on-samples-with-too-large-pes-packets so a different bug tracker. WTF.
comment:8 by , 3 years ago
Insane series of patches to fix this: https://patchwork.ffmpeg.org/project/ffmpeg/patch/20210922172914.17914-4-cus@passwd.hu/
comment:9 by , 3 years ago
Resolution: | → fixed |
---|---|
Status: | open → closed |
Fixed in 9420f7e09560d82ebdb96ddc6724a734f4fe0b95.
proposed patch