Opened 5 years ago

Closed 5 years ago

#6748 closed defect (invalid)

ffmpeg-3.4/libavfilter/window_func.h:133: suspicious assignment ?

Reported by: dcb Owned by:
Priority: normal Component: avfilter
Version: unspecified Keywords:
Cc: Blocked By:
Blocking: Reproduced by developer: no
Analyzed by developer: no


ffmpeg-3.4/libavfilter/window_func.h:133]: (style) Boolean value assigned to floating point variable.

Source code is

for (sum = !n, b = t = j = 1; j <= n && sum != t; b *= (n-j) * (1./j), ++j)

Change History (2)

comment:1 by jkqxz, 5 years ago

Looks fine? The loop doesn't run and sum is 1.0 if n is zero. (I guess it could be written in a less opaque way, patches welcome.)

comment:2 by Elon Musk, 5 years ago

Resolution: invalid
Status: newclosed
Note: See TracTickets for help on using tickets.