aac in flv decoding broken

[Carl Eugen Hoyos]

​http://ffmpeg.org/pipermail/ffmpeg-devel/2017-May/211408.html
A user provided an flv file containing aac that cannot be decoded since 6f69f7a8bf6a0d013985578df2ef42ee6b1c7994

$ ffmpeg -i aac_decoding_error.flv -t 0.1 -f null -
ffmpeg version N-86108-g355e27e Copyright (c) 2000-2017 the FFmpeg developers
  built with gcc 7.1.0 (GCC)
  configuration: --enable-gpl
  libavutil      55. 63.100 / 55. 63.100
  libavcodec     57. 96.101 / 57. 96.101
  libavformat    57. 72.101 / 57. 72.101
  libavdevice    57.  7.100 / 57.  7.100
  libavfilter     6. 89.101 /  6. 89.101
  libswscale      4.  7.101 /  4.  7.101
  libswresample   2.  8.100 /  2.  8.100
  libpostproc    54.  6.100 / 54.  6.100
[aac @ 0x2f39980] channel element 0.3 is not allocated
Input #0, flv, from 'aac_decoding_error.flv':
  Duration: 00:19:24.15, start: 1143.758000, bitrate: 0 kb/s
    Stream #0:0: Audio: aac, 44100 Hz, stereo, fltp
Stream mapping:
  Stream #0:0 -> #0:0 (aac (native) -> pcm_s16le (native))
Press [q] to stop, [?] for help
[aac @ 0x2f54b40] channel element 0.3 is not allocated
Error while decoding stream #0:0: Invalid data found when processing input
[aac @ 0x2f54b40] channel element 0.14 is not allocated
Error while decoding stream #0:0: Invalid data found when processing input
[aac @ 0x2f54b40] Input buffer exhausted before END element found
Error while decoding stream #0:0: Invalid data found when processing input
[aac @ 0x2f54b40] Input buffer exhausted before END element found
Error while decoding stream #0:0: Invalid data found when processing input
[aac @ 0x2f54b40] channel element 2.10 is not allocated
Error while decoding stream #0:0: Invalid data found when processing input
[aac @ 0x2f54b40] Input buffer exhausted before END element found
Error while decoding stream #0:0: Invalid data found when processing input
[aac @ 0x2f54b40] Sample rate index in program config element does not match the sample rate index configured by the container.
[aac @ 0x2f54b40] decode_pce: Input buffer exhausted before END element found
Error while decoding stream #0:0: Operation not permitted
[aac @ 0x2f54b40] Input buffer exhausted before END element found
Error while decoding stream #0:0: Invalid data found when processing input
[aac @ 0x2f54b40] Sample rate index in program config element does not match the sample rate index configured by the container.
[aac @ 0x2f54b40] decode_pce: Input buffer exhausted before END element found
Error while decoding stream #0:0: Operation not permitted
[aac @ 0x2f54b40] Multiple frames in a packet.
[aac @ 0x2f54b40] decode_pce: Input buffer exhausted before END element found
Error while decoding stream #0:0: Operation not permitted
Output #0, null, to 'pipe:':
  Metadata:
    encoder         : Lavf57.72.101
    Stream #0:0: Audio: pcm_s16le, 44100 Hz, mono, s16, 705 kb/s
    Metadata:
      encoder         : Lavc57.96.101 pcm_s16le
[aac @ 0x2f54b40] Input buffer exhausted before END element found
Error while decoding stream #0:0: Invalid data found when processing input
[aac @ 0x2f54b40] channel element 1.12 is not allocated
Error while decoding stream #0:0: Invalid data found when processing input
[aac @ 0x2f54b40] Input buffer exhausted before END element found
Error while decoding stream #0:0: Invalid data found when processing input
[aac @ 0x2f54b40] channel element 3.14 is not allocated
Error while decoding stream #0:0: Invalid data found when processing input
[aac @ 0x2f54b40] channel element 0.3 is not allocated
Error while decoding stream #0:0: Invalid data found when processing input
[aac @ 0x2f54b40] skip_data_stream_element: Input buffer exhausted before END element found
Error while decoding stream #0:0: Invalid data found when processing input
[aac @ 0x2f54b40] Input buffer exhausted before END element found
Error while decoding stream #0:0: Invalid data found when processing input
[aac @ 0x2f54b40] channel element 0.7 is not allocated
Error while decoding stream #0:0: Invalid data found when processing input
[aac @ 0x2f54b40] Input buffer exhausted before END element found
Error while decoding stream #0:0: Invalid data found when processing input
[aac @ 0x2f54b40] Input buffer exhausted before END element found
Error while decoding stream #0:0: Invalid data found when processing input
[aac @ 0x2f54b40] Input buffer exhausted before END element found
Error while decoding stream #0:0: Invalid data found when processing input
[aac @ 0x2f54b40] Input buffer exhausted before END element found
Error while decoding stream #0:0: Invalid data found when processing input
[aac @ 0x2f54b40] channel element 0.0 is not allocated
Error while decoding stream #0:0: Invalid data found when processing input
[aac @ 0x2f54b40] Input buffer exhausted before END element found
Error while decoding stream #0:0: Invalid data found when processing input
[aac @ 0x2f54b40] Input buffer exhausted before END element found
Error while decoding stream #0:0: Invalid data found when processing input
[aac @ 0x2f54b40] Input buffer exhausted before END element found
Error while decoding stream #0:0: Invalid data found when processing input
[aac @ 0x2f54b40] channel element 3.12 is not allocated
Error while decoding stream #0:0: Invalid data found when processing input
size=N/A time=00:00:00.40 bitrate=N/A speed= 267x
video:0kB audio:2kB subtitle:0kB other streams:0kB global headers:0kB muxing overhead: unknown
Conversion failed!

[peloverde]

I've bisected the change to:

commit 6f69f7a8bf6a0d013985578df2ef42ee6b1c7994 (HEAD)
Merge: 60b75186b2 9200514ad8
Author: Derek Buitenhuis <​derek.buitenhuis@gmail.com>
Date: Sun Apr 10 20:58:15 2016 +0100

Merge commit '9200514ad8717c63f82101dc394f4378854325bf'

• commit '9200514ad8717c63f82101dc394f4378854325bf': lavf: replace AVStream.codec with AVStream.codecpar

This has been a HUGE effort from:

• Derek Buitenhuis <​derek.buitenhuis@gmail.com>
• Hendrik Leppkes <​h.leppkes@gmail.com>
• wm4 <​nfxjfg@googlemail.com>
• Clément Bœsch <​clement@stupeflix.com>
• James Almer <​jamrial@gmail.com>
• Michael Niedermayer <​michael@niedermayer.cc>
• Rostislav Pehlivanov <​atomnuker@gmail.com>

Merged-by: Derek Buitenhuis <​derek.buitenhuis@gmail.com>

Remuxing this samples to FLV at n3.0, decodes fine at current master.

[Carl Eugen Hoyos]

Replying to peloverde:

I've bisected the change to:

commit 6f69f7a8bf6a0d013985578df2ef42ee6b1c7994

Isn't this the same commit I mentioned above?

[Carl Eugen Hoyos]

Fixed by Alex Converse in 4d2b9ece45e576474a2f03eb47f5cc088eec3f0c