Opened 8 years ago

Closed 8 years ago

#6096 closed defect (fixed)

ALAC decoder does not set sample rate on context

Reported by: Devin Tuchsen Owned by:
Priority: normal Component: avcodec
Version: git-master Keywords: alac
Cc: Blocked By:
Blocking: Reproduced by developer: no
Analyzed by developer: no

Description

Summary of the bug: ALAC decoder does not set sample rate on its AVCodecContext. This is inconsistent with other decoders, e.g., Vorbis, Opus, FLAC.

How to reproduce: After opening an ALAC decoder in a project using libavcodec, attempt to get sample rate via avctx->sample_rate.

ffmpeg version: 3.2.git
built on 16-01-18

Attachments (1)

patchalac.diff​ (1.1 KB ) - added by Carl Eugen Hoyos 8 years ago.

Download all attachments as: .zip

Change History (6)

by Carl Eugen Hoyos, 8 years ago

Attachment: patchalac.diff​ added

comment:1 by Carl Eugen Hoyos, 8 years ago

Keywords: apple lossless decoder removed

Please test attached patch.

comment:2 by Devin Tuchsen, 8 years ago

Tested the attached patch; I did not find any issues.

comment:3 by Carl Eugen Hoyos, 8 years ago

Does the patch work for your use-case?

comment:4 by Devin Tuchsen, 8 years ago

Yes, it does.

comment:5 by Carl Eugen Hoyos, 8 years ago

Resolution: → fixed
Status: new → closed

Applied as 12f7c091e8044a70c8d0d4cca156bf3223c2ad5d, thank you for testing the patch!

Note: See TracTickets for help on using tickets.