Support writing album cover art image embedded in ogg / opus metadata

[llogan]

$ ./ffmpeg -i ../fate-suite/cover_art/cover_art.flac ../out.ogg
ffmpeg version N-71319-g43b4342 Copyright (c) 2000-2015 the FFmpeg developers
  built with gcc 4.9.2 (GCC) 20150304 (prerelease)
  configuration: --enable-gpl --disable-doc
  libavutil      54. 22.100 / 54. 22.100
  libavcodec     56. 34.100 / 56. 34.100
  libavformat    56. 29.100 / 56. 29.100
  libavdevice    56.  4.100 / 56.  4.100
  libavfilter     5. 13.101 /  5. 13.101
  libswscale      3.  1.101 /  3.  1.101
  libswresample   1.  1.100 /  1.  1.100
  libpostproc    53.  3.100 / 53.  3.100
Input #0, flac, from '../fate-suite/cover_art/cover_art.flac':
  Metadata:
    RATING          : 0
    ALBUM           : Ангелофрения
    ARTIST          : Мельница
    TITLE           : Дороги
    TRACKTOTAL      : 11
    TOTALTRACKS     : 11
    GENRE           : Folk
    DATE            : 2012
    track           : 2
  Duration: 00:03:09.05, start: 0.000000, bitrate: 1 kb/s
    Stream #0:0: Audio: flac, 44100 Hz, stereo, s16
    Stream #0:1: Video: mjpeg, yuvj420p(pc, bt470bg/unknown/unknown), 350x350 [SAR 1:1 DAR 1:1], 90k tbr, 90k tbn, 90k tbc
    Metadata:
      comment         : Other
Output #0, ogg, to '../out.ogg':
  Metadata:
    RATING          : 0
    ALBUM           : Ангелофрения
    ARTIST          : Мельница
    TITLE           : Дороги
    TRACKTOTAL      : 11
    TOTALTRACKS     : 11
    GENRE           : Folk
    DATE            : 2012
    track           : 2
    Stream #0:0: Video: theora, none, q=2-31, 128 kb/s
    Metadata:
      comment         : Other
    Stream #0:1: Audio: flac, 0 channels, 128 kb/s
Stream mapping:
  Stream #0:1 -> #0:0 (mjpeg (native) -> ? (?))
  Stream #0:0 -> #0:1 (flac (native) -> flac (native))
Encoder (codec theora) not found for output stream #0:0

Of course if Theora is supported by the build then a Theora video stream will be outputted (90k frame rate in this case).

Possibly related to #4442 since I assume the cover art mechanics would be similar:
​https://wiki.xiph.org/VorbisComment#Cover_art

[James]

I wrote a patch a couple years ago implementing FLAC's METADATA_BLOCK_PICTURE structure: https://ffmpeg.org/pipermail/ffmpeg-devel/2013-August/146869.html

As discussed in that thread, it's been on hold until a proper AVPacketList API is implemented in order to avoid duplicating code, but it could nonetheless be committed as is.
Feel free to resurrect that thread to see what's people opinion in the matter.

After that it would be a matter of sharing that code so the Ogg muxer can also make use of it.

[James]

Related to ticket #4442

[mitar]

It would be really useful if somebody could revive this patch.

[Justin Case]

Hello,

I am also interested in this request resolution.

Here is a patch someone pointed to me:

​https://patchwork.ffmpeg.org/project/ffmpeg/list/?series=7314

It allows ffmpeg to embed an image into an ogg container as a metadata field containing binary data, just ​like opusenc --picture mycover.jpg does. This follows the ​FLAC specification.

Please can a developer merge this to mainstream if the code is OK?

Cheers,
Justin

PS: here is a ​question on SE describing the need

[yiltiyekni]

+1 for this one. It would be really nice for my project. Looking forward for the fix.

[yiltiyekni]

+1 for this one. It would be really nice for my project. Looking forward for the fix.

[iconoclasthero]

+1

It really sucks this has been an issue for a decade and there's been a solution for better than a year and it hasn't been implemented.

[mitar]

Which solution has there been?

[microchip]

How long is this going to take? Instead of trolling on IRC and arguing endlessly on the ML, get into the code and implement it!