Opened 5 years ago

Closed 5 years ago

#2277 closed defect (fixed)

wrong comment in the alac.c

Reported by: chinshou Owned by:
Priority: minor Component: avcodec
Version: git-master Keywords: alac
Cc: Blocked By:
Blocking: Reproduced by developer: no
Analyzed by developer: no

Description

alac.c has wrong comment:

  • 8bit initial history (14)
  • 8bit rice param limit (10)

it should be

  • 8bit initial history (10)
  • 8bit rice param limit (14)

see following code alacenc.c for correct init parameter value

Initialize default Rice parameters
s->rc.history_mult = 40;
s->rc.initial_history = 10;
s->rc.k_modifier = 14;

I have attached a patch for it

Attachments (1)

alac.patch (499 bytes) - added by chinshou 5 years ago.

Download all attachments as: .zip

Change History (3)

Changed 5 years ago by chinshou

comment:1 Changed 5 years ago by cehoyos

  • Keywords alac added
  • Status changed from new to open

Please send patches to ffmpeg-devel, they receive more attention on the mailing list.

comment:2 Changed 5 years ago by michael

  • Resolution set to fixed
  • Status changed from open to closed

Patch applied

Note: See TracTickets for help on using tickets.