Opened 11 years ago

Closed 11 years ago

#193 closed defect (fixed)

black bar when converting monow for certain horizontal resolutions

Reported by: ami_stuff Owned by:
Priority: normal Component: swscale
Version: git-master Keywords:
Cc: Blocked By:
Blocking: Reproduced by developer: yes
Analyzed by developer: no

Description

Thanks Stefano for fixing ticket 154, but I found some problems with another file.

  1. when I convert attached image to bmp, there will be visisble black bar in the output image at the right side
  1. when I convert the attached image to tiff, ffplay will decode it incorrectly.
C:\>ffmpeg -i C:\bikerace.pbm out.tiff
ffmpeg version git-N-29815-gde545d2, Copyright (c) 2000-2011 the FFmpeg develope
rs
  built on May 11 2011 14:36:19 with gcc 4.5.3
  configuration: --enable-gpl --enable-version3 --enable-memalign-hack --enable-
runtime-cpudetect --enable-avisynth --enable-bzlib --enable-frei0r --enable-libo
pencore-amrnb --enable-libopencore-amrwb --enable-libfreetype --enable-libgsm --
enable-libmp3lame --enable-libopenjpeg --enable-librtmp --enable-libschroedinger
 --enable-libspeex --enable-libtheora --enable-libvorbis --enable-libvpx --enabl
e-libx264 --enable-libxavs --enable-libxvid --enable-zlib --pkg-config=pkg-confi
g
  libavutil    51.  2. 1 / 51.  2. 1
  libavcodec   53.  5. 0 / 53.  5. 0
  libavformat  53.  0. 3 / 53.  0. 3
  libavdevice  53.  0. 0 / 53.  0. 0
  libavfilter   2.  5. 0 /  2.  5. 0
  libswscale    0. 14. 0 /  0. 14. 0
Input #0, image2, from 'C:\bikerace.pbm':
  Duration: 00:00:00.04, start: 0.000000, bitrate: N/A
    Stream #0.0: Video: pbm, monow, 550x423, 25 tbr, 25 tbn, 25 tbc
[buffer @ 01DA1B80] w:550 h:423 pixfmt:monow tb:1/1000000 sar:0/1
Output #0, image2, to 'out.tiff':
  Metadata:
    encoder         : Lavf53.0.3
    Stream #0.0: Video: tiff, monow, 550x423, q=2-31, 200 kb/s, 90k tbn, 25 tbc
Stream mapping:
  Stream #0.0 -> #0.0
Press [q] to stop encoding
frame=    1 fps=  0 q=0.0 Lsize=      -0kB time=0.04 bitrate=  -4.4kbits/s
video:27kB audio:0kB global headers:0kB muxing overhead -100.079751%

C:\>ffplay out.tiff
ffplay version git-N-29815-gde545d2, Copyright (c) 2003-2011 the FFmpeg develope
rs
  built on May 11 2011 14:36:19 with gcc 4.5.3
  configuration: --enable-gpl --enable-version3 --enable-memalign-hack --enable-
runtime-cpudetect --enable-avisynth --enable-bzlib --enable-frei0r --enable-libo
pencore-amrnb --enable-libopencore-amrwb --enable-libfreetype --enable-libgsm --
enable-libmp3lame --enable-libopenjpeg --enable-librtmp --enable-libschroedinger
 --enable-libspeex --enable-libtheora --enable-libvorbis --enable-libvpx --enabl
e-libx264 --enable-libxavs --enable-libxvid --enable-zlib --pkg-config=pkg-confi
g
  libavutil    51.  2. 1 / 51.  2. 1
  libavcodec   53.  5. 0 / 53.  5. 0
  libavformat  53.  0. 3 / 53.  0. 3
  libavdevice  53.  0. 0 / 53.  0. 0
  libavfilter   2.  5. 0 /  2.  5. 0
  libswscale    0. 14. 0 /  0. 14. 0
[tiff @ 01E17640] Run went out of bounds
Input #0, image2, from 'out.tiff':
  Duration: 00:00:00.04, start: 0.000000, bitrate: N/A
    Stream #0.0: Video: tiff, monob, 550x423, 25 tbr, 25 tbn, 25 tbc
[ffsink @ 01E22D00] auto-inserting filter 'auto-inserted scaler 0' between the f
ilter 'src' and the filter 'out'
[scale @ 01E22140] w:550 h:423 fmt:monob -> w:550 h:423 fmt:yuv420p flags:0x4
[tiff @ 01E17640] Run went out of bounds
   1.16 A-V:  0.000 s:0.0 aq=    0KB vq=    0KB sq=    0B f=0/0

Attachments (1)

bikerace.pbm (230.6 KB ) - added by ami_stuff 11 years ago.

Download all attachments as: .zip

Change History (5)

by ami_stuff, 11 years ago

Attachment: bikerace.pbm added

comment:1 by Carl Eugen Hoyos, 11 years ago

Component: undeterminedswscale
Reproduced by developer: set
Status: newopen
Version: unspecifiedgit-master

out.tiff in above example is fine, swscale is not.

comment:2 by Carl Eugen Hoyos, 11 years ago

Summary: pbm: problem with mono image with non-space-separated pixel digits when converted to bmp/tiffblack bar when converting monow for certain horizontal resolutions

And please open one ticket per problem.

comment:3 by Stefano Sabatini, 11 years ago

Problem number 2 fixed in commit:

commit 4d15f194b48ad1d92cca2559b6b0db3f0f234528
Author: Stefano Sabatini <stefano.sabatini-lala@poste.it>
Date: Fri May 13 02:07:09 2011 +0200

tiffenc: set bpp table for monow/monob formats


Also makes the bpp_tab non static const, as it needs to be changed in
this case.


Fix encoding of monow/monob images, fix trac issue #193.

Now I confirm that the first problem is related to libswscale, indeed the files are correctly displayed by ImageMagik display, and the files themselves look right, so the problem seems related to monow/monob -> yuv conversion.

comment:4 by Michael Niedermayer, 11 years ago

Resolution: fixed
Status: openclosed

Fixed locally

Note: See TracTickets for help on using tickets.