Opened 2 years ago
Closed 12 months ago
#9983 closed defect (fixed)
Build error with clang on 32 bit Windows
| Reported by: | Christoph Reiter | Owned by: | |
|---|---|---|---|
| Priority: | normal | Component: | avutil |
| Version: | git-master | Keywords: | vulkan |
| Cc: | Blocked By: | ||
| Blocking: | Reproduced by developer: | no | |
| Analyzed by developer: | no |
Description
Looks like clang 15 got stricter somehow:
C:/msys64/home/user/M/mingw-w64-ffmpeg/src/ffmpeg-4.4.2/libavutil/hwcontext_vulkan.c:865:15: error: incompatible pointer to integer conversion assigning to
'VkCommandPool' (aka 'unsigned long long') from 'void *' [-Wint-conversion]
cmd->pool = NULL;
Some searching suggests that VkCommandPool is a handle, and that VK_NULL_HANDLE should be used, but I don't know enough about vulkan. It builds fine with it at least.
Attachments (1)
Change History (7)
by , 2 years ago
| Attachment: | 0003-fix-clang32-build.patch added |
|---|
comment:1 by , 2 years ago
| Component: | undetermined → avutil |
|---|---|
| Keywords: | vulkan added |
| Version: | unspecified → git-master |
comment:2 by , 2 years ago
The configure line is a simple "./configure".
$ clang -v clang version 15.0.3 Target: i686-w64-windows-gnu Thread model: posix InstalledDir: C:/msys64/clang32/bin
I will try to look into providing a patch. I need to read up on the vulkan API first though.
comment:3 by , 21 months ago
Someone proposed a fix on the ML: https://ffmpeg.org/pipermail/ffmpeg-devel/2023-March/307142.html
comment:4 by , 12 months ago
I think this got fixed a while back in https://git.videolan.org/?p=ffmpeg.git;a=patch;h=cc76e8340d28438c1ac56ee7dfd774d25e944264.
comment:5 by , 12 months ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:6 by , 12 months ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Yeah, this can be closed.
It regressed again in the meantime, but that's another issue, and I'll try to upstream that some time: https://github.com/msys2/MINGW-packages/blob/342a841670ecf0aabe3cffd3b57abf2e02945e23/mingw-w64-ffmpeg/0009-wrong-null-type.patch
Please either provide the configure line you tested and clang -v output to make this a valid ticket or - much better - send your patch made with git format-patch to the FFmpeg development mailing list.