Opened 22 months ago

Closed 8 months ago

Last modified 8 months ago

#9816 closed defect (fixed)

Ffmpeg 4.4.x play 24bit ape file with big noise.

Reported by: Song ziming Owned by:
Priority: important Component: avcodec
Version: git-master Keywords: 24bit ape noise regression
Cc: Blocked By:
Blocking: Reproduced by developer: no
Analyzed by developer: no

Description (last modified by Song ziming)

Summary of the bug:

Ffmpeg 4.4.x play 24bit ape with big noise when using ffplay or compiled so.

If simplely revert this commit it works fine:​https://patchwork.ffmpeg.org/project/ffmpeg/patch/20201006001714.19577-1-onemda@gmail.com/

I have tried to dicuss with the author, he will not fix this problem because he want to do other things without coding.

It also works fine in old versions like 4.3.x or other older version.

How to reproduce:

% ffplay APE_48K_24bit_2CH_02_01.ape​
ffmpeg version built on 4.4.x

Other 24bit ape songs have same problem.

Attachments (1)

APE_48K_24bit_2CH_02_01.ape (1.7 MB ) - added by Song ziming 22 months ago.
24bit ape file

Download all attachments as: .zip

Change History (19)

by Song ziming, 22 months ago

Attachment: APE_48K_24bit_2CH_02_01.ape added

24bit ape file

comment:1 by Song ziming, 22 months ago

Description: modified (diff)
Keywords: 24bit ape noise added

comment:2 by Balling, 22 months ago

But the same happons in media player classic and does not appear to happen in ffplay on git-master!!

P.S. Actually, it does happen in ffplay on git-master too.

Last edited 22 months ago by Balling (previous) (diff)

in reply to:  2 comment:3 by Song ziming, 22 months ago

Replying to Balling:

But the same happons in media player classic and does not appear to happen in ffplay on git-master!!

windows mediaplayer works fine.

4.3.x ffplay works fine.

4.4.x ffplay not works.

revert https://patchwork.ffmpeg.org/project/ffmpeg/patch/20201006001714.19577-1-onemda@gmail.com/\
it works fine too.

comment:4 by Balling, 22 months ago

windows mediaplayer works fine.

Not here.

Also we only support git-master, we do not support 4.4 even. So use this and restest: https://github.com/BtbN/FFmpeg-Builds/releases/tag/latest

Last edited 22 months ago by Balling (previous) (diff)

comment:5 by Balling, 22 months ago

In fact it works good with PoverDVD 2019 or 2020.

Last edited 22 months ago by Balling (previous) (diff)

in reply to:  4 comment:6 by Song ziming, 22 months ago

Replying to Balling:

windows mediaplayer works fine.

Not here.

Also we only support git-master, we do not support 4.4 even. So use this and restest: https://github.com/BtbN/FFmpeg-Builds/releases/tag/latest

It can be reproduced by
master ffmpeg-master-latest-win64-lgpl.zip
or ffmpeg-n4.4-latest-win64-lgpl-4.4.zip
when using cmd
ffplay APE_48K_24bit_2CH_02_01.ape

comment:7 by Balling, 22 months ago

Those are not supported here.

in reply to:  7 ; comment:8 by Song ziming, 22 months ago

Replying to Balling:

Those are not supported here.

What are not support? The problem is libavcodec/apedec.c decoder not work well for 24bit ape file... in the 4.4.x branch or master.

in reply to:  8 ; comment:9 by Balling, 22 months ago

Replying to Song ziming:

Replying to Balling:

Those are not supported here.

What are not support? The problem is libavcodec/apedec.c decoder not work well for 24bit ape file... in the 4.4.x branch or master.

We do not support 4.4. I cannot reproduce on master. It does happen on older ffmpeg in VLC e.g., sure.

in reply to:  9 comment:10 by Song ziming, 22 months ago

Replying to Balling:

Replying to Song ziming:

Replying to Balling:

Those are not supported here.

What are not support? The problem is libavcodec/apedec.c decoder not work well for 24bit ape file... in the 4.4.x branch or master.

We do not support 4.4. I cannot reproduce on master. It does happen on older ffmpeg in VLC e.g., sure./tag/latest

I download daily build ffmpeg-master-latest-win64-lgpl.zip from https://github.com/BtbN/FFmpeg-Builds/releases。Unzip it on windows,enter bin folder,run cmd,input :ffplay APE_48K_24bit_2CH_02_01.ape​ . After a few seconds it appears big noise.

comment:11 by Balling, 22 months ago

Status: newopen

Okay, I can reproduce it.

in reply to:  11 comment:12 by Song ziming, 22 months ago

Replying to Balling:

Okay, I can reproduce it.

  1. This commit cause the problem

https://patchwork.ffmpeg.org/project/ffmpeg/patch/20201006001714.19577-1-onemda@gmail.com/
But I cannot make sure just revert this commit is enough.

  1. Please fix it at master and newest 4.4.x branch.

comment:13 by Balling, 22 months ago

Version: 4.4.1git-master

Setting to git-master.

comment:14 by Marton Balint, 22 months ago

Keywords: regression added
Priority: normalimportant

comment:15 by Balling, 12 months ago

No such problem in Adobe Audition.

comment:16 by LD-531, 11 months ago

Git build: 2023-06-04-git-b1c3d81e71 (https://gyan.dev/ffmpeg/builds/ffmpeg-git-full.7z) issue are still. ffplay.exe playing and ffmpeg.exe decoding 24bit ape got BIG noise, no exception or error prompted.

comment:17 by Balling, 8 months ago

Fixed in 80ad0e2198df4e2961928d8304da58df6db77ec4, in fact the sample is bitperfect with the result before the regression, md5 8067d7c880ecacf6b35bb6086f3a5baa for

ffmpeg.exe -i APE_48K_24bit_2CH_02_01.ape -c:a pcm_s24le -f md5 -

Last edited 8 months ago by Balling (previous) (diff)

comment:18 by Balling, 8 months ago

Resolution: fixed
Status: openclosed
Note: See TracTickets for help on using tickets.