Opened 3 years ago

Closed 3 years ago

Last modified 2 years ago

#9793 closed defect (invalid)

Possible memory leak in libavfilter/af_channelsplit.c

Reported by: Matevos Mehrabyan Owned by:
Priority: normal Component: avfilter
Version: git-master Keywords: leak
Cc: Matevos Mehrabyan Blocked By:
Blocking: Reproduced by developer: no
Analyzed by developer: no

Description

In 'init' function of libavfilter/af_channelsplit.c there is an execution path, which leads a memory leak.

Execution path:

On line 76 value of variable 'all' is set to 1.
On line 94 memory is allocated for 'pad.name'.
On line 101 an unimportant action is done.
On line 115 the 'for' cycle is ended.
On line 118 an unimportant action is done.
On line 119 return from function.

The only place where memory of 'pad.name' is deallocated is on line 106. But as the statement on line 101 is executed, then the statement on line 106 will not be executed, because they are in opposite branches.

Attaching git commit hash, so you can follow the lines described above: 3c694967f862dc5e09921438c6cbd191944ac13c

Change History (2)

comment:1 by Elon Musk, 3 years ago

Resolution: invalid
Status: newclosed

The code have no leaks. The pad.name is always freed in generic code.

comment:2 by Carl Eugen Hoyos, 2 years ago

Keywords: memory removed
Note: See TracTickets for help on using tickets.