Regresion due to "avcodec/wmadec: fix WMA gapless playback"
|Reported by:||Mika Fischer||Owned by:|
|Cc:||Mika Fischer||Blocked By:|
|Blocking:||Reproduced by developer:||no|
|Analyzed by developer:||no|
Summary of the bug:
I think the commit 19802d170a304f5853d92e01d0513b9e06897d61, which was applied on 2021-09-12 in and is included in n5.0 and n5.0.1 causes a regression.
This is the (shortened) diff for the test decoding in the patch:
diff --git a/tests/ref/fate/flcl1905 b/tests/ref/fate/flcl1905 index 5f5245ebcf..d702139db8 100644
a b 1 1 packet|[...]|pts=0|pts_time=0.000000|[...] 2 frame|[...]|pts=0|pts_time=0.000000|[...] 3 frame|[...]|pts=N/A|pts_time=N/A|[...] 4 2 frame|[...]|pts=N/A|pts_time=N/A|[...]
As can be seen, the patch causes the first two frames to be dropped, which might be OK to better conform to the MS decoder.
The problem is that only the first frame had the timestamp info from the packet. Since that got dropped, now the first frame decoded from the packet has no timestamp info.
This causes us issues since we assumed that the first audio frame decoded after seeking always has timestamp info.