Opened 2 years ago

Closed 2 years ago

#9549 closed defect (needs_more_info)

libavfilter results in a flaw during veracode scan

Reported by: Bhawna Khosla Owned by:
Priority: important Component: avfilter
Version: git-master Keywords:
Cc: Blocked By:
Blocking: Reproduced by developer: no
Analyzed by developer: no

Description

Veracode Scan of the code where libavfilter is used resulted in a very high flaw.

Flaw : CWE-190 - Integer Overflow or Wraparound

Module: libavfilter.so.7.40.101

Filename : transform.c: 167

Function Name: avfilter_transform

Description: This arithmetic operation results in an integer overflow error. Because the result of this calculation is larger than the maximum possible value for this data type, the result may wrap to become a very small, or negative number, therefore providing an unintended value. Integer overflows can often trigger buffer overflows, which can be exploited to execute arbitrary code.

Change History (5)

comment:1 by Bhawna Khosla, 2 years ago

Priority: normalimportant

comment:2 by mkver, 2 years ago

This function was only ever exported by mistake and was meant to be internal; since the latest major bump, it is internal and has been renamed to ff_affine_transform(). So you need to actually provide a way to trigger this overflow when using this function as intended (which currently is only in the deshake filter); simply passing in a matrix of your choosing is not enough. Can you do so?

Also notice that your version is not even close to git master (the only actually supported version here).

in reply to:  1 comment:3 by Bhawna Khosla, 2 years ago

Replying to Bhawna Khosla:
We are not using the function. But it comes up in veracode scan.

in reply to:  1 comment:4 by Bhawna Khosla, 2 years ago

Replying to Bhawna Khosla:
We are not using the function. But it comes up in veracode scan.

comment:5 by mkver, 2 years ago

Resolution: needs_more_info
Status: newclosed

Reopen this is if you can provide a way to actually trigger this overflow.

Note: See TracTickets for help on using tickets.