Opened 12 years ago

Closed 12 years ago

Last modified 9 years ago

#895 closed defect (fixed)

sunras: support 32bpp

Reported by: ami_stuff Owned by:
Priority: normal Component: avcodec
Version: git-master Keywords: sunrast
Cc: Blocked By:
Blocking: Reproduced by developer: no
Analyzed by developer: no

Description

PIX_FMT_RGBA works correctly on big-endian, PIX_FMT_BGRA on little-endian

C:\>ffmpeg -i 32.ras
ffmpeg version N-36492-g7f83db3, Copyright (c) 2000-2012 the FFmpeg developers
  built on Jan  5 2012 01:57:12 with gcc 4.6.2
  configuration: --enable-gpl --enable-version3 --disable-w32threads --enable-ru
ntime-cpudetect --enable-avisynth --enable-bzlib --enable-frei0r --enable-libope
ncore-amrnb --enable-libopencore-amrwb --enable-libfreetype --enable-libgsm --en
able-libmp3lame --enable-libopenjpeg --enable-librtmp --enable-libschroedinger -
-enable-libspeex --enable-libtheora --enable-libvo-aacenc --enable-libvo-amrwben
c --enable-libvorbis --enable-libvpx --enable-libx264 --enable-libxavs --enable-
libxvid --enable-zlib
  libavutil      51. 34.100 / 51. 34.100
  libavcodec     53. 53.100 / 53. 53.100
  libavformat    53. 29.100 / 53. 29.100
  libavdevice    53.  4.100 / 53.  4.100
  libavfilter     2. 57.101 /  2. 57.101
  libswscale      2.  1.100 /  2.  1.100
  libswresample   0.  5.100 /  0.  5.100
  libpostproc    51.  2.100 / 51.  2.100
[sunrast @ 02645B60] invalid depth
[image2 @ 020E2320] Could not find codec parameters (Video: sunrast)
32.ras: could not find codec parameters

Attachments (3)

32.rar (1.3 MB ) - added by ami_stuff 12 years ago.
patchsunrast32bpp.diff (578 bytes ) - added by Carl Eugen Hoyos 12 years ago.
lead_32bpp.7z (1.1 MB ) - added by ami_stuff 9 years ago.

Change History (13)

by ami_stuff, 12 years ago

Attachment: 32.rar added

comment:1 by Carl Eugen Hoyos, 12 years ago

Component: undeterminedavcodec
Keywords: sunrast added
Priority: normalwish
Reproduced by developer: set
Status: newopen
Type: defectenhancement
Version: unspecifiedgit-master

Do you think the file is meant to be completely transparent? (It is imo likely that it actually should not be transparent at all.)
Could you try to encode an image that is part transparent, part opaque?

by Carl Eugen Hoyos, 12 years ago

Attachment: patchsunrast32bpp.diff added

comment:2 by ami_stuff, 12 years ago

Sorry, I don't know how to create transparent sun raster (if it's possible), so I suggest supporting it without it.

Last edited 12 years ago by ami_stuff (previous) (diff)

comment:3 by Carl Eugen Hoyos, 12 years ago

Blocked By: 869

Mostly fixed, remaining issues depend on ticket #869.

comment:4 by Carl Eugen Hoyos, 12 years ago

Blocked By: 869#869

comment:5 by Elon Musk, 12 years ago

IMHO blocking this bug by another, unrelated bug is pointless. This bug should and can be fixed without waiting for #869 to be fixed.

comment:6 by Carl Eugen Hoyos, 12 years ago

Blocked By: #869869
Resolution: fixed
Status: openclosed

comment:7 by Elon Musk, 12 years ago

ImageMagick displays wrong colors for this sample, what application created this file?

comment:8 by Elon Musk, 12 years ago

Blocked By: 869
Priority: wishnormal
Reproduced by developer: unset
Resolution: fixed
Status: closedreopened
Type: enhancementdefect

Our decoder incorrectly decodes 32bit ras created with ImageMagick.

Need more info about generated sample.

comment:9 by Carl Eugen Hoyos, 12 years ago

Resolution: fixed
Status: reopenedclosed

Attached sample decodes visually incorrect now, but decoder matches what Gimp, ImageMagick and xview do and what the terse specification indicates.

by ami_stuff, 9 years ago

Attachment: lead_32bpp.7z added

comment:10 by ami_stuff, 9 years ago

one more sample

Note: See TracTickets for help on using tickets.