nasm 2.15 generates lot of warnings when compiling ffmpeg.
|Reported by:||Dale Curtis||Owned by:|
|Blocking:||Reproduced by developer:||yes|
|Analyzed by developer:||yes|
Summary of the bug:
nasm is more verbose on the warnings it's generating for misconfigured assembly code as of 2.15. So x86inc.asm generates lots of issues -- specifically the -w+error=macro-params-legacy warning.
Here's a snippet of one of the warnings -- there are many more of the same type:
../../third_party/ffmpeg/libavcodec/x86/qpel.asm:88: error: improperly calling multi-line macro `SETUP_STACK_POINTER' with 0 parameters [-w+error=macro-params-legacy]
../../third_party/ffmpeg/libavutil/x86/x86inc.asm:555: ... from macro `PROLOGUE' defined here
../../third_party/ffmpeg/libavcodec/x86/qpel.asm:88: error: improperly calling multi-line macro `ALLOC_STACK' with 0 parameters [-w+error=macro-params-legacy]
../../third_party/ffmpeg/libavutil/x86/x86inc.asm:558: ... from macro `PROLOGUE' defined here
How to reproduce:
configure and build ToT ffmpeg using nasm 2.15
dav1d's x86inc.asm has fixes for this, but I was unable to merge them without breaking other pieces of code (specifically vf_overlay.asm and one more I don't recall (rv34.asm maybe?), so an expert will need to take a look.
dav1d has the most recent version of x86inc.asm:
Fixes haven't quite made it to the x264 copy yet, but will probably be there soon: