Opened 5 years ago

Closed 5 years ago

#865 closed defect (fixed)

sunras: support 8bpp grayscale

Reported by: ami_stuff Owned by:
Priority: normal Component: avcodec
Version: git-master Keywords: sunrast
Cc: Blocked By:
Blocking: Reproduced by developer: yes
Analyzed by developer: no

Description

C:\>ffmpeg -i gray.ras out.bmp
ffmpeg version N-36193-gf514695, Copyright (c) 2000-2011 the FFmpeg developers
  built on Dec 26 2011 17:50:37 with gcc 4.6.2
  configuration: --enable-gpl --enable-version3 --disable-w32threads --enable-ru
ntime-cpudetect --enable-avisynth --enable-bzlib --enable-frei0r --enable-libope
ncore-amrnb --enable-libopencore-amrwb --enable-libfreetype --enable-libgsm --en
able-libmp3lame --enable-libopenjpeg --enable-librtmp --enable-libschroedinger -
-enable-libspeex --enable-libtheora --enable-libvo-aacenc --enable-libvo-amrwben
c --enable-libvorbis --enable-libvpx --enable-libx264 --enable-libxavs --enable-
libxvid --enable-zlib
  libavutil      51. 33.100 / 51. 33.100
  libavcodec     53. 48.100 / 53. 48.100
  libavformat    53. 28.100 / 53. 28.100
  libavdevice    53.  4.100 / 53.  4.100
  libavfilter     2. 54.100 /  2. 54.100
  libswscale      2.  1.100 /  2.  1.100
  libswresample   0.  5.100 /  0.  5.100
  libpostproc    51.  2.100 / 51.  2.100
[sunrast @ 02645B60] colormap expected
Input #0, image2, from 'gray.ras':
  Duration: 00:00:00.04, start: 0.000000, bitrate: N/A
    Stream #0:0: Video: sunrast, pal8, 1024x768, 25 tbr, 25 tbn, 25 tbc
[buffer @ 020F1340] w:1024 h:768 pixfmt:pal8 tb:1/1000000 sar:0/1 sws_param:
Output #0, image2, to 'out.bmp':
  Metadata:
    encoder         : Lavf53.28.100
    Stream #0:0: Video: bmp, pal8, 1024x768, q=2-31, 200 kb/s, 90k tbn, 25 tbc
Stream mapping:
  Stream #0:0 -> #0:0 (sunrast -> bmp)
Press [q] to stop, [?] for help
[sunrast @ 02645B60] colormap expected
Error while decoding stream #0:0
frame=    0 fps=  0 q=0.0 Lsize=       0kB time=00:00:00.00 bitrate=   0.0kbits/
s
video:0kB audio:0kB global headers:0kB muxing overhead -1.#IND00%
Output file is empty, nothing was encoded (check -ss / -t / -frames parameters i
f used)

hack attached (I don't know how to identify if 8bpp file is in grayscale mode)

Attachments (3)

gray.ras (768.0 KB) - added by ami_stuff 5 years ago.
grayras.diff (1.4 KB) - added by ami_stuff 5 years ago.
grayras2.diff (917 bytes) - added by ami_stuff 5 years ago.

Download all attachments as: .zip

Change History (7)

Changed 5 years ago by ami_stuff

Changed 5 years ago by ami_stuff

comment:1 in reply to: ↑ description ; follow-up: Changed 5 years ago by cehoyos

  • Component changed from undetermined to avcodec
  • Keywords sunrast added
  • Reproduced by developer set
  • Status changed from new to open
  • Version changed from unspecified to git-master

(Does 1 < bpp < 8 exist?)

Replying to ami_stuff:

hack attached (I don't know how to identify if 8bpp file is in grayscale mode)

You could test for maplength in "case 8", remove the "useless colormap" block and change the condition for loading the palette to "avctx->pix_fmt == PIX_FMT_PAL8" (or better maplength until we fix 864).

comment:2 in reply to: ↑ 1 Changed 5 years ago by cehoyos

Replying to cehoyos:

You could test for maplength in "case 8", remove the "useless colormap" block and change the condition for loading the palette to "avctx->pix_fmt == PIX_FMT_PAL8" (or better maplength until we fix 864).

Actually:
You could test for maplength in "case 8" and use it as condition for loading the palette.

comment:3 Changed 5 years ago by ami_stuff

Right, new patch attached.

Changed 5 years ago by ami_stuff

comment:4 Changed 5 years ago by cehoyos

  • Resolution set to fixed
  • Status changed from open to closed

Patch applied, thank you!

Note: See TracTickets for help on using tickets.