Opened 18 months ago

Last modified 17 months ago

#8648 new defect

Bluray M2TS file with separate PCR pid

Reported by: hashbord Owned by:
Priority: normal Component: avformat
Version: git-master Keywords: mpegts
Cc: Marton Balint Blocked By:
Blocking: Reproduced by developer: no
Analyzed by developer: no

Description (last modified by Carl Eugen Hoyos)

Summary of the bug:

When generating one M2TS file, the PCR marks are included in the Video pid. However, from the Blu-ray specification these marks require to be in one alone pid with number 0x1001.

After commit 422f0a61367f068fb8b1b9ab8cc2eee1808c803c the M2TS files generated by FFmpeg are starting to be Blu-ray conformant. However, still some errors are not targeted.

Reading ticket #7842 you can check that the "HDMV" descriptor and the Standard Pids problem are solved. However, the PCR in the pid 0x1001 is missing. Specifically the label M2TS_PCR_PID is defined, but it's never used!

Please, can you fix this error?
Thank you.

Change History (6)

comment:1 by Carl Eugen Hoyos, 18 months ago

Description: modified (diff)
Keywords: mpegts added; bluray m2ts mpegtsenc removed
Version: unspecifiedgit-master

It would be great if you - instead of analysing the issue - could explain how it can be reproduced.

comment:2 by Marton Balint, 18 months ago

Cc: Marton Balint added

I think this can be reproduced by writing any m2ts file.

I have a patch series pending which fixes this, but I am not yet satisfied with it, that is why I have not posted it in ffmpeg-devel. But you can use it in the meantime:

https://github.com/cus/ffmpeg/tree/mpegts2

in reply to:  1 comment:3 by hashbord, 17 months ago

Replying to cehoyos:

It would be great if you - instead of analysing the issue - could explain how it can be reproduced.

Hi cehoyos,

I'm not a developer, so I can't provide a patch. However, I think the problem is well described: when generating M2TS files the result is not conformant with the Bluray specification because the PCR marks are included in the video PID, instead of inside an alone PCR pid.

How to reproduce it? Easy, create one m2ts file: "ffmpeg -i test.mp4 -bsf h264_mp4toannexb test.m2ts". Then you will see that the PCR marks are incrustated in the video pid 0x1011, and not in the expected pid 0x1001.

Futhermore, cus has provided a patch (Thank you man!): https://github.com/cus/ffmpeg/commit/224fac9bc11d9b5879878640c28726f97153e05a

Please, check it.

comment:4 by hashbord, 17 months ago

Please cus, can do you publish a patch in the mailinglist?

comment:5 by hashbord, 17 months ago

Keywords: m2ts bluray pcr added
Priority: normalimportant

Hi cus and cehoyos,

As the solution it's already implemented, I suggest to prepare a patch and publish it in the dev mailinglist. I appreciate the effort done by CUS and I hope his work will be merged.

Regards.

comment:6 by Carl Eugen Hoyos, 17 months ago

Keywords: m2ts bluray pcr removed
Priority: importantnormal
Note: See TracTickets for help on using tickets.