#8638 closed defect (fixed)

the mode of fopen in example 'hw_decode' was wrong when used in windows

Reported by: elite_jwp Owned by:
Priority: minor Component: documentation
Version: git-master Keywords:
Cc: Blocked By:
Blocking: Reproduced by developer: no
Analyzed by developer: no

Description

In the example 'hw_decode.c:225', the code is as below:

 /* open the file to dump raw data */
 output_file = fopen(argv[3], "w+");

Here, the output file wasn't opened with mode "w+b" which would cause the data not be written "as is" in windows.

Change History (4)

comment:1 by Balling, 18 months ago

When you are pressing create please wait for 3-4 seconds. Lol

comment:2 by Carl Eugen Hoyos, 18 months ago

Keywords: hw_decode fopen removed
Version: 4.2git-master

Please confirm that this issue is reproducible with current FFmpeg git head, the only version supported on this bug tracker.

comment:3 by elite_jwp, 17 months ago

Today, I checked the source from the github master and found the issue still be there.

comment:4 by Carl Eugen Hoyos, 14 months ago

Resolution: fixed
Status: newclosed

Should be fixed in 68f637b6f94d25f45eee2e9320e0057a548b92e0, thank you for the report!

Note: See TracTickets for help on using tickets.