Digest authentication failed when password contains '+' character

[k2w2yut]

Summary of the bug:

• Attempting to connect to RTSP with digest authentication by including user:password
• After DESCRIBE failed with 401, received realm and nonce
• Attempting to reconnect will failed
• Check the trace log found that the response MD5 was incorrect generated, therefore, authentication failed

Workaround:

• Replace '+' with another url-safe sign works
• Avoid including plus character '+' in the password (haven't test with other params, and not putting '+' at the end doesn't help)

How to reproduce:

% ffmpeg -loglevel trace  -i "rtsp://test1:Hilook265+@192.168.2.102/Streaming/Channels/101"

[k2w2yut]

loglevel trace fro mthe run

[k2w2yut]

libavformat/httpauth.c make_digest_auth

• Generating A1hash, A2hash logic seems to be legit just for reading the code

I couldn't debug MD5 methods further without recompiled or GDB

[Carl Eugen Hoyos]

Please test current FFmpeg git head, the only version supported on this bug tracker.

[Marton Balint]

This is most probably already fixed in 3004ef1b1b1bcd6bec4ad3509662ab1a4b644149. Reopen if not.