Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#7982 closed defect (fixed)

Invalid left shift encoding r10k

Reported by: Suhwan Owned by:
Priority: important Component: avcodec
Version: git-master Keywords: r10k ubsan
Cc: Blocked By:
Blocking: Reproduced by developer: yes
Analyzed by developer: no

Description

Summary of the bug:
There's two null pointer passed as argument at libavcodec/frame_thread_encoder.c:213:20: and undefined behaviour at libavcodec/r210enc.c:69:28. (left shift of 522 by 22)

How to reproduce:

Run following cmd:
% ffmpeg_g  -t 3 -y -i tmp.avi -map 0 -c:s:1 h263p -c:v r10k -disposition:a r10k -disposition:s adpcm_adx -vframes 64 -aframes 81 tmp_.adx

ffmpeg version N-94142-g3b2082c663 Copyright (c) 2000-2019 the FFmpeg developers

built with clang version 9.0.0 (https://github.com/llvm/llvm-project.git 442a120567a4bc6c59bc754f9edabfb770086f36)

Patches should be submitted to the ffmpeg-devel mailing list and not this bug tracker.

Attachments (2)

tmp.avi​ (282.5 KB ) - added by Suhwan 5 years ago.
gdb_log_7982​ (14.8 KB ) - added by Suhwan 5 years ago.

Download all attachments as: .zip

Change History (5)

by Suhwan, 5 years ago

Attachment: tmp.avi​ added

by Suhwan, 5 years ago

Attachment: gdb_log_7982​ added

comment:1 by Carl Eugen Hoyos, 5 years ago

Component: undetermined → avcodec
Keywords: r10k ubsan added; crash r210enc removed
Reproduced by developer: set
Status: new → open
Summary: null pointer passed at frame_thread_encoder.c:213 and undefined behaviour at r210enc.c → Invalid left shift encoding r10k

Patch sent.

comment:2 by Carl Eugen Hoyos, 5 years ago

Resolution: → fixed
Status: open → closed

Should be fixed in 2828f5b0d8e432ccd686e3c28ff68348d8a45f7e

comment:3 by Kamalalochana Subbaiah, 5 years ago

Please confirm if version 4.0.0 of ffmpeg is affected by the above described vulnerability?

Note: See TracTickets for help on using tickets.