Opened 7 years ago

Closed 7 years ago

#7953 closed enhancement (fixed)

Support smpte2084 transfer function for hevc_videotoolbox and h264_videotoolbox

Reported by: Nomis101 Owned by:
Priority: wish Component: avcodec
Version: git-master Keywords: videotoolbox
Cc: Blocked By:
Blocking: Reproduced by developer: no
Analyzed by developer: no

Description

Trying to encode 4k HDR videos in HandBrake with videotoolbox x264 or x265, I'm seeing the following message:

[hevc_videotoolbox @ 0x7f9707b07000] Transfer function smpte2084 is not supported.
OR
[h264_videotoolbox @ 0x7f9709149600] Transfer function smpte2084 is not supported.

This is triggered from FFmpeg here
​https://github.com/FFmpeg/FFmpeg/blob/98478c05edb674ec429c298fbe593bda493ba60f/libavcodec/videotoolboxenc.c#L931

It would be nice to add the transfer function smpte2084 to videotoolboxenc.c, which has the constant name kCVImageBufferTransferFunction_SMPTE_ST_2084_PQ
​https://developer.apple.com/documentation/corevideo/cvimagebuffer/image_buffer_transfer_function_constants?language=objc

Change History (2)

comment:1 by Carl Eugen Hoyos, 7 years ago

Keywords: videotoolbox added
Priority: normal → wish

comment:2 by Nomis101, 7 years ago

Resolution: → fixed
Status: new → closed

This was fixed here: ​https://github.com/FFmpeg/FFmpeg/commit/391b67fcb58f95b5cc65b75070fd9a3dce4f8ac6

Note: See TracTickets for help on using tickets.