Opened 2 years ago

Closed 2 years ago

#7944 closed defect (fixed)

compilation broken on macOS 10.12

Reported by: criezy Owned by: Thilo Borgmann
Priority: normal Component: avcodec
Version: git-master Keywords:
Cc: Blocked By:
Blocking: Reproduced by developer: yes
Analyzed by developer: yes

Description

Commit 98478c0 breaks compilation on macOS 10.12 as it uses kCVPixelFormatType_420YpCbCr10BiPlanarVideoRange which was introduced in macOS 12.13.

libavcodec/videotoolboxenc.c:767:41: error: use of undeclared identifier 'kCVPixelFormatType_420YpCbCr10BiPlanarFullRange'; did you mean 'kCVPixelFormatType_420YpCbCr8BiPlanarFullRange'?
                                        kCVPixelFormatType_420YpCbCr10BiPlanarFullRange :
                                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                                        kCVPixelFormatType_420YpCbCr8BiPlanarFullRange
/System/Library/Frameworks/CoreVideo.framework/Headers/CVPixelBuffer.h:77:3: note: 'kCVPixelFormatType_420YpCbCr8BiPlanarFullRange' declared here
  kCVPixelFormatType_420YpCbCr8BiPlanarFullRange  = '420f', /* Bi-Planar Component Y'CbCr 8-bit 4:2:0, full-range (luma=[0,255] chroma=[1,255]).  baseAddr points to a big-endian CV...
  ^
libavcodec/videotoolboxenc.c:768:41: error: use of undeclared identifier 'kCVPixelFormatType_420YpCbCr10BiPlanarVideoRange'; did you mean 'kCVPixelFormatType_420YpCbCr8BiPlanarVideoRange'?
                                        kCVPixelFormatType_420YpCbCr10BiPlanarVideoRange;
                                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                                        kCVPixelFormatType_420YpCbCr8BiPlanarVideoRange
/System/Library/Frameworks/CoreVideo.framework/Headers/CVPixelBuffer.h:76:3: note: 'kCVPixelFormatType_420YpCbCr8BiPlanarVideoRange' declared here
  kCVPixelFormatType_420YpCbCr8BiPlanarVideoRange = '420v', /* Bi-Planar Component Y'CbCr 8-bit 4:2:0, video-range (luma=[16,235] chroma=[16,240]).  baseAddr points to a big-endia...
  ^
libavcodec/videotoolboxenc.c:769:28: error: use of undeclared identifier 'kCVPixelFormatType_420YpCbCr10BiPlanarVideoRange'; did you mean 'kCVPixelFormatType_420YpCbCr8BiPlanarVideoRange'?
        *av_pixel_format = kCVPixelFormatType_420YpCbCr10BiPlanarVideoRange;
                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                           kCVPixelFormatType_420YpCbCr8BiPlanarVideoRange

Change History (3)

comment:1 by Thilo Borgmann, 2 years ago

Analyzed by developer: set
Owner: set to Thilo Borgmann
Reproduced by developer: set
Status: newopen

We are already aware of that. You could apply the patch from the mailing list to have a workaround for the time being. We'll patch current git HEAD accordingly soonish.

See:
https://lists.ffmpeg.org/pipermail/ffmpeg-devel/2019-May/244049.html

Thanks for reporting!

comment:2 by Thilo Borgmann, 2 years ago

Analyzed by developer: set
Owner: set to Thilo Borgmann
Reproduced by developer: set
Status: newopen

We are already aware of that. You could apply the patch from the mailing list to have a workaround for the time being. We'll patch current git HEAD accordingly soonish.

See:
https://lists.ffmpeg.org/pipermail/ffmpeg-devel/2019-May/244049.html

Thanks for reporting!

comment:3 by Rick Kern, 2 years ago

Resolution: fixed
Status: openclosed

Fixed in 268ab17c519f4e34783956092c9edf3ef2c4e280.

Tested with:

./configure --extra-ldflags="-arch x86_64 -mmacosx-version-min=10.12 -isysroot/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.12.sdk" --extra-cflags="-mmacosx-version-min=10.12 -arch x86_64 -isysroot/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.12.sdk"

Note: See TracTickets for help on using tickets.