Opened 10 years ago

Closed 10 years ago

#789 closed defect (fixed)

zzufed .pcm puts ffmpeg in a loop

Reported by: Oana Stratulat Owned by:
Priority: important Component: avcodec
Version: git-master Keywords: aac
Cc: Blocked By:
Blocking: Reproduced by developer: yes
Analyzed by developer: no

Description

==3551== Memcheck, a memory error detector
==3551== Copyright (C) 2002-2010, and GNU GPL'd, by Julian Seward et al.
==3551== Using Valgrind-3.6.1-Debian and LibVEX; rerun with -h for copyright info
==3551== Command: ffmpeg -i corruptfile -f null -
==3551==
ffmpeg version N-35936-gaf3f2a8, Copyright (c) 2000-2011 the FFmpeg developers

built on Dec 19 2011 00:07:16 with gcc 4.6.1
configuration:
libavutil 51. 32. 0 / 51. 32. 0
libavcodec 53. 46. 0 / 53. 46. 0
libavformat 53. 26. 0 / 53. 26. 0
libavdevice 53. 4. 0 / 53. 4. 0
libavfilter 2. 53. 0 / 2. 53. 0
libswscale 2. 1. 0 / 2. 1. 0

==3551==
==3551== HEAP SUMMARY:
==3551== in use at exit: 1,105,236 bytes in 6 blocks
==3551== total heap usage: 15 allocs, 9 frees, 2,152,052 bytes allocated
==3551==
==3551== LEAK SUMMARY:
==3551== definitely lost: 0 bytes in 0 blocks
==3551== indirectly lost: 0 bytes in 0 blocks
==3551== possibly lost: 0 bytes in 0 blocks
==3551== still reachable: 1,105,236 bytes in 6 blocks
==3551== suppressed: 0 bytes in 0 blocks
==3551== Rerun with --leak-check=full to see details of leaked memory
==3551==
==3551== For counts of detected and suppressed errors, rerun with: -v
==3551== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 4 from 4)

Attachments (3)

corruptfile (1.5 MB ) - added by Oana Stratulat 10 years ago.
this file creates the loop
valgrind (1.3 KB ) - added by Oana Stratulat 10 years ago.
valgrind report
patchaacloop.diff (844 bytes ) - added by Carl Eugen Hoyos 10 years ago.

Download all attachments as: .zip

Change History (8)

by Oana Stratulat, 10 years ago

Attachment: corruptfile added

this file creates the loop

by Oana Stratulat, 10 years ago

Attachment: valgrind added

valgrind report

comment:1 by Carl Eugen Hoyos, 10 years ago

Component: FFmpegavcodec
Keywords: aac added
Reproduced by developer: set
Status: newopen

comment:2 by Michael Niedermayer, 10 years ago

Maybe the following get_bits_left() could be moved into the loop
but the patch LGTM

by Carl Eugen Hoyos, 10 years ago

Attachment: patchaacloop.diff added

comment:3 by Carl Eugen Hoyos, 10 years ago

Updated patch attached.

comment:4 by Michael Niedermayer, 10 years ago

i think the previous patch was more readable

comment:5 by Carl Eugen Hoyos, 10 years ago

Resolution: fixed
Status: openclosed

I applied the second variants.

Note: See TracTickets for help on using tickets.