Coding Error in decklink_dec.cpp

[dbigler]

Summary of the bug:

Just located a coding error in decklink_dec.cpp

lines 1170 and 1171 should be swapped:
st->codecpar->codec_tag = avcodec_pix_fmt_to_codec_tag((enum AVPixelFormat)st->codecpar->format);
st->codecpar->format = AV_PIX_FMT_0RGB;

as:
st->codecpar->format = AV_PIX_FMT_0RGB;
st->codecpar->codec_tag = avcodec_pix_fmt_to_codec_tag((enum AVPixelFormat)st->codecpar->format);

lines 1176 and 1177 should also be swapped:
st->codecpar->codec_tag = avcodec_pix_fmt_to_codec_tag((enum AVPixelFormat)st->codecpar->format);
st->codecpar->format = AV_PIX_FMT_BGR0;

as:
st->codecpar->format = AV_PIX_FMT_BGR0;
st->codecpar->codec_tag = avcodec_pix_fmt_to_codec_tag((enum AVPixelFormat)st->codecpar->format);

Otherwise the value set in format will have no effect in the call to avcodec_pix_fmt_to_codec_tag().

[Carl Eugen Hoyos]

Please send your patch made with git format-patch to the FFmpeg development mailing list, patches and patch suggestions are ignored here.

[Marton Balint]

Fixed in cb74c33106d08b09ff0a2e395fe0b69828031d63.