Opened 7 years ago
Closed 4 years ago
#6414 closed defect (fixed)
Possible unintended/inconsistant access to "pkt->dts"
Reported by: | Petru Florin Mihancea | Owned by: | |
---|---|---|---|
Priority: | minor | Component: | avformat |
Version: | git-master | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Reproduced by developer: | no | |
Analyzed by developer: | no |
Description
While experimenting with a CodeSonar plugin we develop, we noticed a potential bug in file "FFmpeg/libavformat/mux.c" line 735:
if (s->internal->avoid_negative_ts_use_pts) {
if (pkt->pts != AV_NOPTS_VALUE && pkt->pts < 0) {
av_log(s, AV_LOG_WARNING, "failed to avoid negative "
"pts %s in stream %d.\n"
"Try -avoid_negative_ts 1 as a possible workaround.\n",
/*Line 735*/ av_ts2str(pkt->dts),
pkt->stream_index
);
}
Shouldn't you access pkt->pts (instead of pkt->dts) as in the guard of the second if? Even the string message mentions "pts".
How to reproduce:
The issue has been detected directly at the source code level in the third party code of the chromium project that uses this code.
Change History (3)
comment:1 by , 7 years ago
Summary: | Possible unintended/unintended access to "pkt->dts" → Possible unintended/inconsistant access to "pkt->dts" |
---|
comment:2 by , 7 years ago
comment:3 by , 4 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Fixed in 1a36354698fc0453ba4d337786d2cb4d3e374cfb.
It probably should, but its only logging so its hardly a bug worth writing home about.