Opened 8 years ago

Closed 8 years ago

#5862 closed defect (fixed)

A clipping value of ADPCM is different from specifications.

Reported by: kei_kissinger Owned by:
Priority: normal Component: avcodec
Version: git-master Keywords: ADPCM
Cc: Blocked By:
Blocking: Reproduced by developer: no
Analyzed by developer: no

Description

source code: adpcm.c
function: adpcm_yamaha_expand_nibble
line: c->step = av_clip(c->step, 127, 24567);
fail: 24567 must be 24576.

reference about specification:
​http://nemesis.hacking-cult.org/MegaDrive/Documentation/YM2608J.PDF -- scanned image in japanese. page 44 (5)

​http://nemesis.hacking-cult.org/MegaDrive/Documentation/YM2608J%20Translated.PDF -- translated into English. page 44 (5)

also another dokument,
​http://www.dtech.lv/files_ym/ym2610.pdf page 6 und 7

Thank you.

Change History (2)

comment:1 by Carl Eugen Hoyos, 8 years ago

Keywords: 24567 removed

Please send a patch made with git format-patch to the development mailing list.

comment:2 by Elon Musk, 8 years ago

Resolution: → fixed
Status: new → closed

Fixed in ee4aa388b2231e988eccdab652c55df080d6ad45.

Note: See TracTickets for help on using tickets.