Opened 5 years ago

Closed 5 years ago

#548 closed defect (fixed)

ffplay in fullscreen mode shows greenish image on osx 10.6.6 with libsdl 1.2.14

Reported by: cbsrobot Owned by:
Priority: normal Component: ffplay
Version: git-master Keywords: sdl
Cc: Blocked By:
Blocking: Reproduced by developer: no
Analyzed by developer: no

Description

colors are greenish in fullscreen mode, but ok in window mode - see attachment.

Maybe this is related to the issue:
http://forums.libsdl.org/viewtopic.php?t=6768&sid=ebc8e29fdcde2a301c0e7c723dca2696

"mplayer -vo sdl file" shows correct colors for both modes.

Attachments (1)

osx-libsdl-bug.jpg (16.0 KB) - added by cbsrobot 5 years ago.

Download all attachments as: .zip

Change History (6)

Changed 5 years ago by cbsrobot

comment:1 Changed 5 years ago by cehoyos

I assume this is without the patch from ticket #546 attached.
Do you see the same problem with the patch attached?

comment:2 Changed 5 years ago by cbsrobot

Yes the same problem occurs with the patch - but at least it does not crash anymore. The subject I wrote is wrong: the blue channel does not get displayed, so the image is more yellowish.

I installed latest libsdl from hg and am trying to resolve the issue within libsdl atm.

If somebody is interested to chime in: I found following comment in SDL_QuarzVideo.m, but I'm not sure if it still valid:

    /*
     * This is a big hassle, needing QuickDraw and QuickTime on older
     *  systems, and god knows what on 10.6, so we immediately fail here,
     *  which causes SDL to make an RGB surface and manage the YUV overlay
     *  in software. Sorry. Use SDL 1.3 if you want YUV rendering in a pixel
     *  shader.  :)
     */
    /*device->CreateYUVOverlay = QZ_CreateYUVOverlay;*/

So I tried to modify the rgba bitmasks (in the QZ_SetVideoMode function in the same file) and either I get Fullscreen working properly or Windowed mode, but never both and although this function gets called when switching from/to fullscreen/window, the rgba bitmasks do not get updated or the rgba bitmasks get redefined somewhere else ... I'm still digging.

comment:3 Changed 5 years ago by cehoyos

Do you see the wrong colours with both ffplay -fs and ffplay and pressing "f"?

comment:4 Changed 5 years ago by cbsrobot

When starting with -fs or without the colors are correct. Only when switching from/to fullscreen, the blue channel disappears.

comment:5 Changed 5 years ago by cehoyos

  • Resolution set to fixed
  • Status changed from new to closed

I believe this has been fixed.

Note: See TracTickets for help on using tickets.