Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#543 closed defect (fixed)

cdg: set AV_PKT_FLAG_KEY

Reported by: Guillaume Desmottes Owned by:
Priority: normal Component: avformat
Version: git-master Keywords: cdg
Cc: Blocked By:
Blocking: Reproduced by developer: yes
Analyzed by developer: no

Description

While integrating cdg support into gstreamer-ffmpeg ( https://bugzilla.gnome.org/show_bug.cgi?id=653493 ) I had to set the AV_PKT_FLAG_KEY on its packet to get it working.

I'm not a ffmpeg (or gst) expert but that seems like the right thing to do as this codec doesn't rely on key frames.

Attachments (2)

0001-cdg.c-set-AV_PKT_FLAG_KEY-flag.patch (666 bytes ) - added by Guillaume Desmottes 12 years ago.
patch
a.cdg (1.8 MB ) - added by Guillaume Desmottes 12 years ago.
cdg file

Download all attachments as: .zip

Change History (6)

by Guillaume Desmottes, 12 years ago

patch

comment:2 by Michael Niedermayer, 12 years ago

Keywords: cdg added
Reproduced by developer: set
Resolution: fixed
Status: newclosed
Version: unspecifiedgit-master

Thanks for pointing at this problem, ive succeeded to fix this in a way with which seeking works with my test file and only a subset of frames marked as keyframes.
Ill push it into master git after a bit more testing.
Also if you find files with which my fix doesnt work, please report them to us.

comment:3 by Guillaume Desmottes, 12 years ago

I tried using cdg.c from efb1ce28b26b66f1f72f85fcdfaf16d7fe6519fe and that doesn't work properly.

gst does decode the video but some frames are missing and it's not synced with the audio.

My gst-ffmpeg patch is https://bugzilla.gnome.org/show_bug.cgi?id=653493#c6
I'm attaching my test app and files as well.

by Guillaume Desmottes, 12 years ago

Attachment: a.cdg added

cdg file

comment:4 by Guillaume Desmottes, 12 years ago

I use: "gst-launch filesrc location=a.cdg ! ffdemux_cdg ! ffdec_cdgraphics ! ffmpegcolorspace ! ximagesink"

Note: See TracTickets for help on using tickets.