Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#4925 closed defect (fixed)

New API in kvazaar 0.7 (doesn't build with --enable-libkvazaar)

Reported by: marillat Owned by:
Priority: normal Component: build system
Version: 2.8.1 Keywords: libkvazaar
Cc: Blocked By:
Blocking: Reproduced by developer: no
Analyzed by developer: no

Description

In kvazaar 0.7 the API has been changed in encoder_encode() and thus ffmpeg doesn't build with --enable-libkvazaar with the following error :

CC	libavcodec/libkvazaar.o
libavcodec/libkvazaar.c: In function ‘libkvazaar_encode’:
libavcodec/libkvazaar.c:176:10: error: too few arguments to function ‘ctx->api->encoder_encode’
     if (!ctx->api->encoder_encode(ctx->encoder, img_in, &data_out, &len_out, NULL)) {
          ^
libavcodec/libkvazaar.c:186:9: warning: ‘ff_alloc_packet’ is deprecated [-Wdeprecated-declarations]
         retval = ff_alloc_packet(avpkt, len_out);
         ^
In file included from libavcodec/libkvazaar.c:30:0:
libavcodec/internal.h:227:33: note: declared here
 attribute_deprecated int ff_alloc_packet(AVPacket *avpkt, int size);
                                 ^
common.mak:57: recipe for target 'libavcodec/libkvazaar.o' failed

Change History (8)

comment:1 follow-up: Changed 4 years ago by cehoyos

What FFmpeg version are you testing?

comment:2 in reply to: ↑ 1 Changed 4 years ago by marillat

Replying to cehoyos:

What FFmpeg version are you testing?

2.8 and 2.8.1

comment:3 follow-up: Changed 4 years ago by cehoyos

  • Component changed from undetermined to build system
  • Keywords libkvazaar added
  • Status changed from new to open
  • Version changed from unspecified to 2.8.1

Untested patch sent.

comment:4 Changed 4 years ago by cehoyos

  • Resolution set to fixed
  • Status changed from open to closed

comment:5 in reply to: ↑ 3 Changed 4 years ago by marillat

Replying to cehoyos:

Untested patch sent.

The patch is the one in c2db8ebc083e5fa35def204321a225960beede84 ?

comment:6 Changed 4 years ago by cehoyos

Yes.

comment:7 Changed 4 years ago by marillat

Maybe not the best way to fix a bug report by disabling feature, especially when git master is already ported to kvazaar >= 0.7

comment:8 Changed 4 years ago by cehoyos

I suspect this is how a release series is defined: Changing the version of an external dependency can't be ok...

Note: See TracTickets for help on using tickets.