Opened 6 years ago

Closed 6 years ago

#4745 closed defect (fixed)

FFmpeg 2.7.2 fails to build on MIPS

Reported by: Brad Smith Owned by:
Priority: normal Component: avcodec
Version: git-master Keywords: mips
Cc: Blocked By:
Blocking: Reproduced by developer: no
Analyzed by developer: yes

Description

Switching from FFmpeg 2.7 to 2.7.2 there has been a regression with building on MIPS. The build uses all of the various command line parameters to disable the various MIPS features for newer chips..

--disable-loongson3 --disable-mips32r5 --disable-mips64r6 --disable-mipsdspr1 --disable-mipsdspr2 --disable-msa

The compiler is GCC 4.2.1.

The build fails like so..

In file included from libavcodec/mips/hevcdsp_init_mips.c:21:
./libavcodec/mips/hevcdsp_mips.h:35:1: error: pasting
"ff_hevc_put_hevc_pel_pixels" and "##" does not give a valid preprocessing
token

Attachments (2)

hevcdsp_mips.h.gcc42.diff (708 bytes ) - added by James 6 years ago.
hevcdsp_mips.h.gcc42.diff-2 (2.8 KB ) - added by Brad Smith 6 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 by Carl Eugen Hoyos, 6 years ago

Priority: importantnormal

Please update your compiler and please test current FFmpeg git head.
To make this a valid ticket, please provide your configure line, run make V=1 several times and provide the complete, uncut console output of the last run.

comment:2 by Brad Smith, 6 years ago

I'll check git master, but the compiler isn't changing. This is what it has to build with and what we've used to build FFmpeg for quite a few releases now.

by James, 6 years ago

Attachment: hevcdsp_mips.h.gcc42.diff added

comment:3 by James, 6 years ago

Are you sure it worked with ffmpeg 2.7, or you meant to say 2.6?
The line that gives that error has been in the tree since the 2.7 release and hasn't changed since. The entire mips folder apparently hasn't changed from 2.7 to 2.7.2, even.

Can you try the attached patch and see if it fixes the error for you?

comment:4 by Brad Smith, 6 years ago

Ok, taking your patch and expanding upon it to cover the other macros that were having issues compiling it is now compiled Ok and working.

by Brad Smith, 6 years ago

Attachment: hevcdsp_mips.h.gcc42.diff-2 added

comment:5 by James, 6 years ago

Analyzed by developer: set
Keywords: mips added
Status: newopen
Version: 2.7git-master

Patch to fix this on the ml.

comment:6 by Brad Smith, 6 years ago

Great, thank you.

comment:7 by James, 6 years ago

Resolution: fixed
Status: openclosed

Fixed in a0092cea462ff4f203aaff09c42c6731c6516b44 and backported for ffmpeg 2.7.3

Note: See TracTickets for help on using tickets.