Opened 9 years ago
Closed 9 years ago
#4745 closed defect (fixed)
FFmpeg 2.7.2 fails to build on MIPS
Reported by: | Brad Smith | Owned by: | |
---|---|---|---|
Priority: | normal | Component: | avcodec |
Version: | git-master | Keywords: | mips |
Cc: | Blocked By: | ||
Blocking: | Reproduced by developer: | no | |
Analyzed by developer: | yes |
Description
Switching from FFmpeg 2.7 to 2.7.2 there has been a regression with building on MIPS. The build uses all of the various command line parameters to disable the various MIPS features for newer chips..
--disable-loongson3 --disable-mips32r5 --disable-mips64r6 --disable-mipsdspr1 --disable-mipsdspr2 --disable-msa
The compiler is GCC 4.2.1.
The build fails like so..
In file included from libavcodec/mips/hevcdsp_init_mips.c:21:
./libavcodec/mips/hevcdsp_mips.h:35:1: error: pasting
"ff_hevc_put_hevc_pel_pixels" and "##" does not give a valid preprocessing
token
Attachments (2)
Change History (9)
comment:1 by , 9 years ago
Priority: | important → normal |
---|
comment:2 by , 9 years ago
I'll check git master, but the compiler isn't changing. This is what it has to build with and what we've used to build FFmpeg for quite a few releases now.
by , 9 years ago
Attachment: | hevcdsp_mips.h.gcc42.diff added |
---|
comment:3 by , 9 years ago
Are you sure it worked with ffmpeg 2.7, or you meant to say 2.6?
The line that gives that error has been in the tree since the 2.7 release and hasn't changed since. The entire mips folder apparently hasn't changed from 2.7 to 2.7.2, even.
Can you try the attached patch and see if it fixes the error for you?
comment:4 by , 9 years ago
Ok, taking your patch and expanding upon it to cover the other macros that were having issues compiling it is now compiled Ok and working.
by , 9 years ago
Attachment: | hevcdsp_mips.h.gcc42.diff-2 added |
---|
comment:5 by , 9 years ago
Analyzed by developer: | set |
---|---|
Keywords: | mips added |
Status: | new → open |
Version: | 2.7 → git-master |
Patch to fix this on the ml.
comment:7 by , 9 years ago
Resolution: | → fixed |
---|---|
Status: | open → closed |
Fixed in a0092cea462ff4f203aaff09c42c6731c6516b44 and backported for ffmpeg 2.7.3
Please update your compiler and please test current FFmpeg git head.
To make this a valid ticket, please provide your configure line, run
make V=1
several times and provide the complete, uncut console output of the last run.