Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#4472 closed defect (wontfix)

AAC copy from stream without encoding fails

Reported by: steinrr Owned by:
Priority: important Component: undetermined
Version: git-master Keywords: mkv aac regression
Cc: Blocked By:
Blocking: Reproduced by developer: no
Analyzed by developer: no

Description

Summary of the bug:

The commit referenced below breaks capturing valid AAC streams without reencoding them. The change from WARNING to ERROR makes it impossible to capture streams that were captured OK earlier.

https://github.com/FFmpeg/FFmpeg/commit/51da7d02748cc54b7d009115e76efa940b99a8ef

This is the earlier version:
http://i58.tinypic.com/4t27pg.png

This is the new version with the commit:
http://i58.tinypic.com/3451nok.png

How to reproduce:

Fails:

ffmpeg -i http://nordond6c-f.akamaihd.net/i/wo/open/90/90e13dea4c96346aa7874839eb9b66dc1101d689/90e13dea4c96346aa7874839eb9b66dc1101d689_,141,316,563,1266,2250,.mp4.csmil/index_4_av.m3u8 -map 0:v -map 0:a -c copy test.mkv

Works (with libvorbis encoding of AAC):

ffmpeg -i http://nordond6c-f.akamaihd.net/i/wo/open/90/90e13dea4c96346aa7874839eb9b66dc1101d689/90e13dea4c96346aa7874839eb9b66dc1101d689_,141,316,563,1266,2250,.mp4.csmil/index_4_av.m3u8 -map 0:v -map 0:a -c:v copy test.mkv

Change History (5)

comment:1 by steinrr, 7 years ago

Note: The command line that now fails - did work in previous versions without the commit.

comment:2 by Carl Eugen Hoyos, 7 years ago

Keywords: mkv aac regression added
Priority: normalimportant
Resolution: wontfix
Status: newclosed
Version: 2.6.1git-master

For future tickets: Please always test current FFmpeg git head and always provide your failing command line together with the complete, uncut console output. Do not provide screen shots unless specifically asked to.

It was decided that this ticket will not be fixed, the output files were invalid:
http://thread.gmane.org/gmane.comp.video.ffmpeg.devel/191255/focus=191334

comment:3 by Carl Eugen Hoyos, 7 years ago

Related to ticket #3175.

comment:4 by steinrr, 7 years ago

I see that the output files might "theoretically" be invalid, but the output files produced byt the old version clearly worked fine in MKV players. This patch degrades the usefulness of ffmpeg and makes it incompatible with e.g. NRK which is the main television network in Norway.

What is the issue by having a warning as before, and let the user decide if this is "useful enough" for him?

Last edited 7 years ago by steinrr (previous) (diff)

comment:5 by Carl Eugen Hoyos, 7 years ago

If you really want this reverted (I hope you realize that I agree to some degree with you), I suggest you post an answer to the email I linked above or send an alternative (simpler) patch that just reverts the offending commit.

Note: See TracTickets for help on using tickets.