Opened 8 years ago
Closed 2 years ago
#4455 closed defect (fixed)
Better dependency tracking for ffprobe FATE tests needed
|Reported by:||Timothy Gu||Owned by:|
|Blocking:||Reproduced by developer:||yes|
|Analyzed by developer:||no|
Right now, ffprobe tests uses
tests/data/ffprobe-test.nut, which depends on
ffmpeg$(EXESUF). However, ffprobe tests are not disabled with ffmpeg is disabled, like when
--disable-avdevice is passed. This leads to errors when testing ffprobe.
There are two variants:
GEN tests/data/ffprobe-test.nut /home/ux/fate/ffmpeg/tests/Makefile:47: recipe for target 'tests/data/ffprobe-test.nut' failed make: *** [tests/data/ffprobe-test.nut] Error 1
make: *** No rule to make target 'ffmpeg', needed by 'tests/data/ffprobe-test.nut'.
Change History (4)
comment:1 by , 8 years ago
|Reproduced by developer:||set|
|Status:||new → open|
|Version:||unspecified → git-master|
by , 8 years ago
comment:2 by , 8 years ago
Fixed an error in my first comment and sent a patch to change the test file so the audio stream gets disposition default.
comment:3 by , 2 years ago
|Status:||open → closed|
Fixed in 4845f6687d4f1ddcb1ed57b09b09f284e8500fc1 (it added a dependency on avdevice; one could do this in a more fine-grained manner, but it fixes the issue as reported).
FFprobe tests are disabled if ffmpeg is disabled,ffmpeg does not depend on avdevice.
The FFprobe tests depend on a file that can currently only be created if avdevice was enabled, I will attach a patch that works around this issue by not using avdevice when creating the file. Unfortunately, it slightly changes the output file because the audio stream gets a default stream (this may or may not be related to ticket #3622).
A solution would be to first change the test file so the audio stream will be set to default and then apply my patch.