libx264 check broken in 2.5 (ok in HEAD)

[nieder]

Summary of the bug:

The configure check for libx264 in the 2.5 release is broken.

How to reproduce:

$ ./configure --enable-libx264 --enable-gpl
./configure: line 4915: syntax error near unexpected token `}'
./configure: line 4915: `                                 warn "using libx264 without pkg-config"; } } &&'

The check in configure from git HEAD is ok (uses use_pkg_config() as the first check attempt and is preceded by an opening `{' ).

Tested on OS X but this looks like it should be a universal failure.

[michael]

configure is identical between master/HEAD and release/2.5, also it works fine here on linux

[cehoyos]

Please reopen if you can add information about your system.

$ git checkout master
$ git pull
$ ./configure --enable-gpl --enable-libx264

...

WARNING: pkg-config not found, library detection may fail.
WARNING: using libx264 without pkg-config

$ git checkout n2.5
$ ./configure --enable-gpl --enable-libx264

...

WARNING: pkg-config not found, library detection may fail.
WARNING: using libx264 without pkg-config

[nieder]

Ugh. I had applied an unrelated test change to a different section in configure and accidentally screwed up the libx264 detection code. Sorry about the noise.