Opened 9 years ago

Closed 7 years ago

#4105 closed defect (wontfix)

RC_Lookahead RC-Lookahead inconsistency

Reported by: Atarikid Owned by:
Priority: normal Component: avcodec
Version: git-master Keywords: libvpx libx264
Cc: Blocked By:
Blocking: Reproduced by developer: no
Analyzed by developer: no

Description

There is a huge inconsistency between RC_Lookahead RC-Lookahead

For VP8 it is:
RC_Lookahead

For all other:
RC-Lookahead

Why is this?

Change History (5)

comment:1 by Carl Eugen Hoyos, 9 years ago

Component: undeterminedavcodec
Keywords: libvpx libx264 added

With "all other", do you mean libx264?

Please consider sending a patch to the developer mailing list if you want to change one of them.

comment:2 by Atarikid, 9 years ago

Not sure it is my decision which to use.
Peeking at the past rc-lookahead is always used.

Making the vp8 rc_lookahead out of place. I suggest renaming that to rc-lookahead too.

comment:3 by Atarikid, 9 years ago

Not sure it is my decision which to use.
Peeking at the past rc-lookahead is always used.

Making the vp8 rc_lookahead out of place. I suggest renaming that to rc-lookahead too.

comment:4 by jzern, 8 years ago

At the time it was added rc_lookahead matched libx264. That was changed to rc-lookahead to match x264 and in libvpx lag-in-frames was added to match vpxenc. rc_lookahead was left in libvpxenc for compatibility.

comment:5 by Carl Eugen Hoyos, 7 years ago

Resolution: wontfix
Status: newclosed

Feel free to send a patch made with git format-patch to the development mailing list.

Note: See TracTickets for help on using tickets.