Opened 5 years ago

Closed 5 years ago

#3870 closed defect (fixed)

Incorrect AVSampleFormat for sample_fmts_s16p (libavcodec/adpcm.c)

Reported by: avclubn00b Owned by:
Priority: minor Component: avcodec
Version: git-master Keywords: adpcm
Cc: Blocked By:
Blocking: Reproduced by developer: no
Analyzed by developer: no

Description

As of git: ea97859c8c218b83ab747a7eabcb88ca446f6751 line 1533 in libavcodec/adpcm.c contains:

static const enum AVSampleFormat sample_fmts_s16p[] = { AV_SAMPLE_FMT_S16,

I believe it should contain:

static const enum AVSampleFormat sample_fmts_s16p[] = { AV_SAMPLE_FMT_S16P,

Note the trailing "P" for the planar format.

I am truly sorry if this is wrong place to report this. I looked around on the site for sometime before deciding here was better than nowhere.

Change History (3)

comment:1 in reply to: ↑ description ; follow-up: Changed 5 years ago by cehoyos

  • Keywords planar audio removed

Replying to avclubn00b:

I am truly sorry if this is wrong place to report this.

It is the wrong place.
Please send your patch (as unified diff as produced by git format-patch) to the ffmpeg-devel mailing list, patches are often ignored on this bug tracker.

comment:2 in reply to: ↑ 1 Changed 5 years ago by avclubn00b

Replying to cehoyos:

Replying to avclubn00b:

I am truly sorry if this is wrong place to report this.

It is the wrong place.
Please send your patch (as unified diff as produced by git format-patch) to the ffmpeg-devel mailing list, patches are often ignored on this bug tracker.

Thank you, cehoyos. I have mailed a patch to ffempg-devel. Please feel free to close this.

comment:3 Changed 5 years ago by cehoyos

  • Resolution set to fixed
  • Status changed from new to closed

Your patch was applied as 18e70006 - thank you for the report and the fix!

Note: See TracTickets for help on using tickets.