Opened 6 years ago

Closed 5 years ago

#3482 closed enhancement (fixed)

New mode for showwaves filter

Reported by: mrskman Owned by:
Priority: wish Component: avfilter
Version: git-master Keywords: showwaves
Cc: Blocked By:
Blocking: Reproduced by developer: no
Analyzed by developer: no

Description

If you generate a wave with showwave filter set to mode=point, you can get a result which is almost invisible because of high resolution (points are too far from each other).

I suggest to add new mode=p2p which draws a line between those points and makes output more readable.

I tried to do it on my own and here is the result:

Example 1 - http://www.datafilehost.com/d/5b822974 (mode=point on top, mode=p2p on bottom)
Example 2 - http://www.datafilehost.com/d/f0457d43 (mode=p2p standalone)
Patch: http://www.datafilehost.com/d/af6aafad

It's not perfect but it seems better to me. I would be glad if anyone can look at it or even improve it.

Thank you for any reply.

Change History (2)

comment:1 Changed 6 years ago by cehoyos

  • Keywords showwaves added

Please post your patch to the ffmpeg-devel mailing list, where it can be reviewed. Patches on the bug tracker are often ignored, patches on external websites can even disappear.
If you believe it was unclear that patches should not be posted here, please tell us!

comment:2 Changed 5 years ago by cehoyos

  • Resolution set to fixed
  • Status changed from new to closed

Your patch was applied as 6f3e15af - thank you!

Note: See TracTickets for help on using tickets.