Opened 6 years ago

Closed 6 years ago

#3296 closed defect (fixed)

ffmpeg -> vsLocalmotions2TransformsSimple

Reported by: moroboshi_84 Owned by:
Priority: normal Component: avfilter
Version: git-master Keywords: libvidstab
Cc: Blocked By:
Blocking: Reproduced by developer: yes
Analyzed by developer: yes

Description

Hi,
I try to compile git version of ffmpeg with last git vid.stab library and obtain this error after make process:
CC libavfilter/vf_vidstabtransform.o
libavfilter/vf_vidstabtransform.c: In function ‘config_input’:
libavfilter/vf_vidstabtransform.c:189:13: error: implicit declaration of function ‘vsLocalmotions2TransformsSimple’ [-Werror=implicit-function-declaration]
if (vsLocalmotions2TransformsSimple(td, &mlms, &tc->trans) != VS_OK) {

cc1: some warnings being treated as errors
make: * [libavfilter/vf_vidstabtransform.o] Errore 1
marco@android:~/svn/ffmpeg$ make
CC libavfilter/vf_vidstabtransform.o
libavfilter/vf_vidstabtransform.c: In function ‘config_input’:
libavfilter/vf_vidstabtransform.c:189:13: error: implicit declaration of function ‘vsLocalmotions2TransformsSimple’ [-Werror=implicit-function-declaration]
if (vsLocalmotions2TransformsSimple(td, &mlms, &tc->trans) != VS_OK) {

cc1: some warnings being treated as errors
make:
* [libavfilter/vf_vidstabtransform.o] Errore 1

Attachments (1)

vidstab_fix.patch (814 bytes) - added by MoSal 6 years ago.
Compile fix for vidstab filter

Download all attachments as: .zip

Change History (9)

comment:1 Changed 6 years ago by cehoyos

Please add your FFmpeg version (remember that only git head is normally supported), your configure line and then run make V=1 twice and post the output of the second call here.

comment:2 Changed 6 years ago by moroboshi_84

the version of git is:

marco@android:~/svn/ffmpeg$ ./version.sh
N-59766-ge11983b

the config is:

marco@android:~/svn/ffmpeg$ ./configure --enable-libvidstab --enable-gpl

the make V=1 is:

marco@android:~/svn/ffmpeg$ make V=1
touch .version
gcc -I. -I./ -D_ISOC99_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_POSIX_C_SOURCE=200112 -D_XOPEN_SOURCE=600 -DHAVE_AV_CONFIG_H -std=c99 -fomit-frame-pointer -pthread -I/usr/local/include -D_GNU_SOURCE=1 -D_REENTRANT -I/usr/include/SDL -g -Wdeclaration-after-statement -Wall -Wdisabled-optimization -Wpointer-arith -Wredundant-decls -Wwrite-strings -Wtype-limits -Wundef -Wmissing-prototypes -Wno-pointer-to-int-cast -Wstrict-prototypes -Wno-parentheses -Wno-switch -Wno-format-zero-length -Wno-pointer-sign -O3 -fno-math-errno -fno-signed-zeros -fno-tree-vectorize -Werror=implicit-function-declaration -Werror=missing-prototypes -Werror=return-type -Werror=vla -Wno-maybe-uninitialized -MMD -MF libavfilter/vf_vidstabtransform.d -MT libavfilter/vf_vidstabtransform.o -c -o libavfilter/vf_vidstabtransform.o libavfilter/vf_vidstabtransform.c
libavfilter/vf_vidstabtransform.c: In function ‘config_input’:
libavfilter/vf_vidstabtransform.c:189:13: error: implicit declaration of function ‘vsLocalmotions2TransformsSimple’ [-Werror=implicit-function-declaration]

if (vsLocalmotions2TransformsSimple(td, &mlms, &tc->trans) != VS_OK) {

cc1: some warnings being treated as errors
make: * [libavfilter/vf_vidstabtransform.o] Errore 1

comment:3 Changed 6 years ago by cehoyos

  • Keywords libvidstab added
  • Status changed from new to open

Thank you, do you know the version of libvidstab you have installed?

comment:4 Changed 6 years ago by moroboshi_84

Commit version of vid.stab is 94ac25d84515e94ae6d9186b10cdcf9c84b2a95d, v 0.98...

comment:5 Changed 6 years ago by MoSal

vsLocalmotions2TransformsSimple() was removed in libvidstab's commit 49f74c9e6efc07fc7dc2dfc7878acc8b5e03d8ae.

Using vsLocalmotions2Transforms() instead seems to work.

Changed 6 years ago by MoSal

Compile fix for vidstab filter

comment:6 Changed 6 years ago by llogan

Patches should be sent to the ffmpeg-devel mailing list. They will get more attention there.

comment:7 Changed 6 years ago by MoSal

comment:8 Changed 6 years ago by saste

  • Analyzed by developer set
  • Component changed from undetermined to avfilter
  • Reproduced by developer set
  • Resolution set to fixed
  • Status changed from open to closed

Should be fixed in:

commit 7012a9dc10b9e26cdddf2fad0da28f4535b58a61
Author: Georg Martius <martius@mis.mpg.de>
Date:   Thu Jan 9 22:22:16 2014 +0100

    configure: add version check for pkg libraries, and use it for vidstab
    
    Also fix trac ticket #3296.
    
    Signed-off-by: Georg Martius <martius@mis.mpg.de>
    Signed-off-by: Stefano Sabatini <stefasab@gmail.com>
Note: See TracTickets for help on using tickets.