Opened 4 years ago

Last modified 4 years ago

#2641 open enhancement

Support trailing ; in filter_complex expression

Reported by: jdolan Owned by:
Priority: wish Component: avfilter
Version: 1.2.1 Keywords: filter_complex
Cc: Blocked By:
Blocking: Reproduced by developer: yes
Analyzed by developer: no

Description

Summary of the bug:

It'd be nice if the complex filter parser didn't bomb out with a cryptic error message when a user terminates their filter chains with a trailing ;.

How to reproduce:

% ffmpeg -i "$1" -i "$2" -i "$3" -i "$4" -filter_complex "
    [0:0] pad='max(240\,iw):max(180\,ih):0:0', scale='240:180', pad='480:180:0:0' [left_video];
    [1:0] pad='max(240\,iw):max(180\,ih):0:0', scale='240:180', pad='480:180:240:0' [right_video];
    [left_video] [right_video] overlay;
    
    ...
        
    [0:1] [1:1] amerge;
    " -acodec libfaac -ac 2 -vcodec libx264 -r 15 "$5"

...

[AVFilterGraph @ 0x7fb1cac2c1a0] No such filter: ''

Change History (2)

comment:1 Changed 4 years ago by cehoyos

Does it work with current git head?

Please add a minimal failing command line together with the complete, uncut console output to make this a valid ticket.

comment:2 Changed 4 years ago by ubitux

  • Priority changed from normal to wish
  • Reproduced by developer set
  • Status changed from new to open

We should indeed support those "empty statements".

Note: See TracTickets for help on using tickets.