Opened 14 years ago

Closed 14 years ago

#1613 closed defect (invalid)

twolame detection is deficient (needs to check version/capability)

Reported by: Hanspeter Niederstrasser Owned by:
Priority: normal Component: build system
Version: git-master Keywords:
Cc: Blocked By:
Blocking: Reproduced by developer: no
Analyzed by developer: no

Description

OS X 10.7, Xcode 4.1

When compiling git-master yesterday with --enable-libtwolame added for the first time, I ran into this compilation failure:

CC    libavcodec/libtwolame.o
/src/ffmpeg/libavcodec/libtwolame.c:59:25: error: use of undeclared identifier 'TWOLAME_SAMPLES_PER_FRAME'
    avctx->frame_size = TWOLAME_SAMPLES_PER_FRAME;

I had twolame-0.3.6 installed, including the dev package (headers, etc) during this failure. Updating to twolame-0.3.13, the build succeeded. The twolame configure check needs to check for twolame capabilities, not just the presence of the header and library.

Change History (1)

comment:1 by Elon Musk, 14 years ago

Resolution: → invalid
Status: new → closed

This have been already fixed.

Note: See TracTickets for help on using tickets.