Opened 4 years ago

Closed 15 months ago

#1463 closed enhancement (fixed)

ffmpeg.exe on Windows does not respond properly to Ctrl+Break

Reported by: joewreschnig Owned by:
Priority: normal Component: ffmpeg
Version: git-master Keywords: win
Cc: rogerdpack Blocked By:
Blocking: Reproduced by developer: no
Analyzed by developer: no

Description

In addition to SIGINT, on Windows it is common to send a different signal, SIGBREAK, which has similar effects. This can be triggered by pressing Ctrl+Break or by another process sending a signal.

New process groups on WIn32 usually ignore SIGINT; it is customary to stop a process in a separate process group by sending SIGBREAK.

The attached patch makes ffmpeg.exe respond to SIGBREAK in the same way it does SIGINT, using the WIndows console "control event" handler.

Attachments (1)

ffmpeg-sigbreak.diff (1.7 KB) - added by joewreschnig 4 years ago.
Patch against ~2012.06.18 git branch

Download all attachments as: .zip

Change History (8)

Changed 4 years ago by joewreschnig

Patch against ~2012.06.18 git branch

comment:1 Changed 4 years ago by cehoyos

  • Keywords win added
  • Status changed from new to open
  • Version changed from unspecified to git-master

Please send patches to ffmpeg-devel, they receive more attention there.

comment:2 follow-up: Changed 3 years ago by rogerdpack

appears this wasn't "quite" committed yet...as of today anyway...http://web.archiveorange.com/archive/v/4q4BhNEWTcX2aCpF2IWz

comment:3 in reply to: ↑ 2 Changed 3 years ago by cehoyos

  • Cc rogerdpack added

Replying to rogerdpack:

appears this wasn't "quite" committed yet...as of today anyway...http://web.archiveorange.com/archive/v/4q4BhNEWTcX2aCpF2IWz

If you want to push this patch, please resend a tested version to ffmpeg-devel. Posting a link (especially a non-working one) unfortunately does not help.

comment:4 Changed 3 years ago by rogerdpack

comment:5 Changed 3 years ago by cehoyos

If you are interested in this issue please consider reading my last comment.

comment:6 Changed 15 months ago by rogerdpack

(I would note also that ctrl+c [or sending the process the CTRL_C_EVENT] does/did already work, FWIW).

comment:7 Changed 15 months ago by rogerdpack

  • Resolution set to fixed
  • Status changed from open to closed

OK finally got a commit in for this, thanks for the patch!

Note: See TracTickets for help on using tickets.