Opened 12 years ago

Closed 9 years ago

#1463 closed enhancement (fixed)

ffmpeg.exe on Windows does not respond properly to Ctrl+Break

Reported by: Joe Wreschnig Owned by:
Priority: normal Component: ffmpeg
Version: git-master Keywords: win
Cc: Roger Pack Blocked By:
Blocking: Reproduced by developer: no
Analyzed by developer: no

Description

In addition to SIGINT, on Windows it is common to send a different signal, SIGBREAK, which has similar effects. This can be triggered by pressing Ctrl+Break or by another process sending a signal.

New process groups on WIn32 usually ignore SIGINT; it is customary to stop a process in a separate process group by sending SIGBREAK.

The attached patch makes ffmpeg.exe respond to SIGBREAK in the same way it does SIGINT, using the WIndows console "control event" handler.

Attachments (1)

ffmpeg-sigbreak.diff (1.7 KB ) - added by Joe Wreschnig 12 years ago.
Patch against ~2012.06.18 git branch

Download all attachments as: .zip

Change History (8)

by Joe Wreschnig, 12 years ago

Attachment: ffmpeg-sigbreak.diff added

Patch against ~2012.06.18 git branch

comment:1 by Carl Eugen Hoyos, 12 years ago

Keywords: win added
Status: newopen
Version: unspecifiedgit-master

Please send patches to ffmpeg-devel, they receive more attention there.

comment:2 by Roger Pack, 11 years ago

appears this wasn't "quite" committed yet...as of today anyway...http://web.archiveorange.com/archive/v/4q4BhNEWTcX2aCpF2IWz

in reply to:  2 comment:3 by Carl Eugen Hoyos, 11 years ago

Cc: Roger Pack added

Replying to rogerdpack:

appears this wasn't "quite" committed yet...as of today anyway...http://web.archiveorange.com/archive/v/4q4BhNEWTcX2aCpF2IWz

If you want to push this patch, please resend a tested version to ffmpeg-devel. Posting a link (especially a non-working one) unfortunately does not help.

comment:5 by Carl Eugen Hoyos, 11 years ago

If you are interested in this issue please consider reading my last comment.

comment:6 by Roger Pack, 9 years ago

(I would note also that ctrl+c [or sending the process the CTRL_C_EVENT] does/did already work, FWIW).

comment:7 by Roger Pack, 9 years ago

Resolution: fixed
Status: openclosed

OK finally got a commit in for this, thanks for the patch!

Note: See TracTickets for help on using tickets.