Opened 7 weeks ago

Last modified 4 weeks ago

#11334 new defect

[Trac] Wiki content format regression

Reported by: MasterQuestionable Owned by:
Priority: important Component: trac
Version: unspecified Keywords: TracWiki CSS
Cc: MasterQuestionable Blocked By:
Blocking: Reproduced by developer: no
Analyzed by developer: no

Description (last modified by MasterQuestionable)

͏    Some recent change broke the content display, by unjustifiably appending "?" after certain content:
͏    https://trac.ffmpeg.org/ticket/11139#comment:6
͏    https://trac.ffmpeg.org/ticket/11071#ticket
͏    https://trac.ffmpeg.org/wiki/colorspace
͏    https://trac.ffmpeg.org/wiki/denoise
͏    .
͏    Similar to:
͏    https://trac.ffmpeg.org/wiki/MasterQuestionable?action=diff&version=1
͏    ; that required extra escaping:
͏    https://trac.ffmpeg.org/ticket/10829?action=comment-diff&cnum=4&version=1

͏    For <colorspace>, the "tags" display is also abnormal. (since Trac 1.6)

Change History (13)

comment:1 by MasterQuestionable, 7 weeks ago

͏    Much is essentially:
͏    https://trac.ffmpeg.org/ticket/10921
͏    https://github.com/orgs/community/discussions/16929#discussioncomment-3151079
͏    .
͏    Bothersome is the cumbersome wrestling.
͏    (escaping plaintext to plaintext...)

comment:2 by MasterQuestionable, 6 weeks ago

Keywords: CSS added
Priority: normalimportant

͏    An effective fix to this issue is:
͏    Outright disabling the highlight for missing links ("a.missing").
͏    .
͏    The highlight in almost all cases provides no benefit.
͏    And fails in particular hard in such:
͏    https://trac.ffmpeg.org/ticket/11354 (PlayStation, GitHub, ...)

͏    Locally addressable via (uBO):
͏    trac.ffmpeg.org##a:remove-class("missing")

͏    Relevant CSS in:
͏    https://trac.ffmpeg.org/chrome/common/css/trac.css

͏    Note:
͏    Preferably to be addressed from CSS: else potentially another regression for contents that "properly" escaped...

comment:3 by Balling, 6 weeks ago

"And fails in particular hard in such:
͏ ​https://trac.ffmpeg.org/ticket/11354 (PlayStation, GitHub, ...)"

Yeah, hate when that happens... basically anything that is CamelCase.

Last edited 6 weeks ago by Balling (previous) (diff)

comment:4 by MasterQuestionable, 6 weeks ago

͏    I have several Trac related feedbacks with direct fix available.
͏    While there seems to be no one pushing the change?

comment:5 by Timo R., 6 weeks ago

If you know how to just turn that feature off, please let us know.

comment:6 by MasterQuestionable, 6 weeks ago

͏    Well, most my changes are patching the CSS files.
͏    (mostly minor changes)

͏    All Trac related of me:
͏    https://trac.ffmpeg.org/query?cc=~MasterQuestionable&component=trac&col=id&col=type&col=summary&col=component&col=keywords&col=reporter&col=status&col=resolution&col=time&col=changetime&order=changetime&desc=1&max=500

͏    Disable the highlight from Trac (instead of CSS fix) may cause another regression, aforementioned.
[ ^
͏    It didn't, seems. The highlight has been disabled.
͏    But the problem has not been completely addressed: CSS patching still needed. ]

͏    ----

͏    Should I simply attach the patched version of various files instead..?

Last edited 5 weeks ago by MasterQuestionable (previous) (diff)

comment:7 by Timo R., 6 weeks ago

The css file is generated by trac.
I can change settings in tracs ini file, to enable/disable modules and turn on or off settings of loaded modules.
I don't want to start patching trac itself beyond the few changes we already have, since it makes any future updates an absolute pain.
So if there is no setting to achieve the desired behaviour, it'll first need to be implemented upstream.

Last edited 5 weeks ago by Timo R. (previous) (diff)

comment:8 by MasterQuestionable, 6 weeks ago

͏    So maybe I shall look at:
͏    https://trac.edgewall.org/wiki/HowToContribute
͏    ; instead?

͏    Nevertheless, it must support custom CSS override.
͏    (the appearance here is apparently different from the official demo)

comment:9 by Timo R., 6 weeks ago

To my knowledge, there are no overrides.
The only thing we modify is the trac.ini, and a few select backports of upstream patches that fix issues.
All other differences come from a different set of enabled modules and their settings.

comment:10 by MasterQuestionable, 6 weeks ago

͏    I'll investigate more later.
͏    Probably something to do with the "modules".

comment:11 by MasterQuestionable, 5 weeks ago

͏    As general reference:
͏    That displays the ͏"ffmpeg-logo.png" mostly would be related to the user styles.
͏    (so possibly the relevant CSS, or page content controls)

comment:12 by MasterQuestionable, 5 weeks ago

͏    I recommend disabling the changeset highlight too:
͏    https://trac.ffmpeg.org/ticket/11110#comment:10 (alike "r3191")
͏    https://trac.ffmpeg.org/ticket/11369#ticket (pointless "#0", "#0:0" alike)
͏    [ ^ #2 is actually ticket highlight. But #0 seems invalid regardless... ]


͏    For the changeset linking, I recommend linking directly to:
͏    https://github.com/FFmpeg/FFmpeg/commit/${ID}

͏    Also the changeset display in:
͏    https://trac.ffmpeg.org/timeline
͏    ; is probably meaningless:
͏    Severe clipping of descriptions most of the time.
͏    .
͏    Preferably simply link to:
͏    https://github.com/FFmpeg/FFmpeg/commits
͏    (more pleasant viewing experience)

comment:13 by MasterQuestionable, 4 weeks ago

Description: modified (diff)

͏    Temporary timeline workaround:
͏    https://trac.ffmpeg.org/timeline?milestone&ticket&ticket_details&wiki&tags
͏    (maybe the setting is preferred default?)

Note: See TracTickets for help on using tickets.