Opened 4 years ago

Closed 4 years ago

#10126 closed defect (fixed)

TrueHD decoding regression

Reported by: cgbug Owned by: Elon Musk
Priority: important Component: avcodec
Version: git-master Keywords: thd regression
Cc: Blocked By:
Blocking: Reproduced by developer: no
Analyzed by developer: no

Description

​Sample file

Regression since ​e35af6bcef2cc3d370d257ba2466468d9ab3cdb3

Lots of audible artifacts.
Log spawns "Lossless check failed" errors.

Change History (8)

comment:1 by Balling, 4 years ago

Status: new → open

Yep.

comment:2 by Balling, 4 years ago

Keywords: thd added; truehd removed

So, newer versions decode only 4 channels instead of 8, other are silent.

Last edited 4 years ago by Balling (previous) (diff)

comment:3 by cgbug, 4 years ago

Debug log has:
"Previous substream(0) channels overlaps current substream(1) channels, skipping."

Commenting out the "goto next_substr" in that if block gives good sound and 8 channel output again.

comment:4 by Carl Eugen Hoyos, 4 years ago

Keywords: regression added
Priority: critical → important

comment:5 by Balling, 4 years ago

Owner: set to Elon Musk

comment:6 by Elon Musk, 4 years ago

This hack you propose is in direct conflict with another fix.

There is probably nicer way to support both files.

comment:8 by Balling, 4 years ago

Resolution: → fixed
Status: open → closed

Fixed in fc9a3b584da3cf3fc1f00036be2eaf5dff903ccf, in fact the 24 bit wavs are bitperfect with before regression.

Note: See TracTickets for help on using tickets.