Opened 17 months ago
Closed 16 months ago
#10126 closed defect (fixed)
TrueHD decoding regression
Reported by: | cgbug | Owned by: | Elon Musk |
---|---|---|---|
Priority: | important | Component: | avcodec |
Version: | git-master | Keywords: | thd regression |
Cc: | Blocked By: | ||
Blocking: | Reproduced by developer: | no | |
Analyzed by developer: | no |
Description
Regression since e35af6bcef2cc3d370d257ba2466468d9ab3cdb3
Lots of audible artifacts.
Log spawns "Lossless check failed" errors.
Change History (8)
comment:1 by , 17 months ago
Status: | new → open |
---|
comment:2 by , 17 months ago
Keywords: | thd added; truehd removed |
---|
So, newer versions decode only 4 channels instead of 8, other are silent.
comment:3 by , 17 months ago
Debug log has:
"Previous substream(0) channels overlaps current substream(1) channels, skipping."
Commenting out the "goto next_substr" in that if block gives good sound and 8 channel output again.
comment:4 by , 17 months ago
Keywords: | regression added |
---|---|
Priority: | critical → important |
comment:5 by , 16 months ago
Owner: | set to |
---|
comment:6 by , 16 months ago
This hack you propose is in direct conflict with another fix.
There is probably nicer way to support both files.
comment:7 by , 16 months ago
comment:8 by , 16 months ago
Resolution: | → fixed |
---|---|
Status: | open → closed |
Fixed in fc9a3b584da3cf3fc1f00036be2eaf5dff903ccf, in fact the 24 bit wavs are bitperfect with before regression.
Yep.