Opened 7 years ago

Closed 13 months ago

#6033 closed enhancement (fixed)

unsharp filter documentetion additional description.

Reported by: nicol Owned by:
Priority: minor Component: documentation
Version: git-master Keywords: unsharp
Cc: Blocked By:
Blocking: Reproduced by developer: no
Analyzed by developer: no

Description

Summary of the bug: Setting unsharp filter more than 28 adds luma_msize_x and luma_msize_y, chroma_msize_x and chroma_msize_y to an error.
So I should describe under 26 adds luma_msize_x and luma_msize_y, chroma_msize_x and chroma_msize_y.

Documentation
https://ffmpeg.org/ffmpeg-filters.html#unsharp-1

Source code
https://github.com/FFmpeg/FFmpeg/blob/master/libavfilter/vf_unsharp.c#L144

How to reproduce:

% ffmpeg -v 9 -loglevel 99 -f lavfi -i color=c=white:size=640x360,unsharp=lx=5:ly=23:la=-1:cx=5:cy=5:ca=0 -t 1 error0.mp4
ffmpeg version N-82785-g6b95da9 Copyright (c) 2000-2016 the FFmpeg developers
  built with gcc 5.4.0 (GCC)
  configuration: --enable-gpl --enable-version3 --disable-w32threads --enable-dxva2 --enable-libmfx --enable-n
venc --enable-avisynth --enable-bzlib --enable-fontconfig --enable-frei0r --enable-gnutls --enable-iconv --ena
ble-libass --enable-libbluray --enable-libbs2b --enable-libcaca --enable-libfreetype --enable-libgme --enable-
libgsm --enable-libilbc --enable-libmodplug --enable-libmp3lame --enable-libopencore-amrnb --enable-libopencor
e-amrwb --enable-libopenh264 --enable-libopenjpeg --enable-libopus --enable-librtmp --enable-libschroedinger -
-enable-libsnappy --enable-libsoxr --enable-libspeex --enable-libtheora --enable-libtwolame --enable-libvidsta
b --enable-libvo-amrwbenc --enable-libvorbis --enable-libvpx --enable-libwavpack --enable-libwebp --enable-lib
x264 --enable-libx265 --enable-libxavs --enable-libxvid --enable-libzimg --enable-lzma --enable-decklink --ena
ble-zlib
  libavutil      55. 41.101 / 55. 41.101
  libavcodec     57. 66.109 / 57. 66.109
  libavformat    57. 58.101 / 57. 58.101
  libavdevice    57.  2.100 / 57.  2.100
  libavfilter     6. 68.100 /  6. 68.100
  libswscale      4.  3.101 /  4.  3.101
  libswresample   2.  4.100 /  2.  4.100
  libpostproc    54.  2.100 / 54.  2.100
Splitting the commandline.
Reading option '-v' ... matched as option 'v' (set logging level) with argument '9'.
Reading option '-loglevel' ... matched as option 'loglevel' (set logging level) with argument '99'.
Reading option '-f' ... matched as option 'f' (force format) with argument 'lavfi'.
Reading option '-i' ... matched as input url with argument 'color=c=white:size=640x360,unsharp=lx=5:ly=23:la=-
1:cx=5:cy=5:ca=0'.
Reading option '-t' ... matched as option 't' (record or transcode "duration" seconds of audio/video) with arg
ument '1'.
Reading option 'error0.mp4' ... matched as output url.
Finished splitting the commandline.
Parsing a group of options: global .
Applying option v (set logging level) with argument 9.
Successfully parsed a group of options.
Parsing a group of options: input url color=c=white:size=640x360,unsharp=lx=5:ly=23:la=-1:cx=5:cy=5:ca=0.
Applying option f (force format) with argument lavfi.
Successfully parsed a group of options.
Opening an input file: color=c=white:size=640x360,unsharp=lx=5:ly=23:la=-1:cx=5:cy=5:ca=0.
detected 4 logical cores
[Parsed_color_0 @ 0000000000569e80] Setting 'c' to value 'white'
[Parsed_color_0 @ 0000000000569e80] Setting 'size' to value '640x360'
[Parsed_color_0 @ 0000000000569e80] size:640x360 rate:25/1 duration:-1.000000 sar:1/1
[Parsed_unsharp_1 @ 000000000056a940] Setting 'lx' to value '5'
[Parsed_unsharp_1 @ 000000000056a940] Setting 'ly' to value '23'
[Parsed_unsharp_1 @ 000000000056a940] Setting 'la' to value '-1'
[Parsed_unsharp_1 @ 000000000056a940] Setting 'cx' to value '5'
[Parsed_unsharp_1 @ 000000000056a940] Setting 'cy' to value '5'
[Parsed_unsharp_1 @ 000000000056a940] Setting 'ca' to value '0'
[Parsed_unsharp_1 @ 000000000056a940] luma or chroma matrix size too big
[lavfi @ 0000000000566d40] Error initializing filter 'unsharp' with args 'lx=5:ly=23:la=-1:cx=5:cy=5:ca=0'
color=c=white:size=640x360,unsharp=lx=5:ly=23:la=-1:cx=5:cy=5:ca=0: Invalid argument
ffmpeg version N-82785-g6b95da9
built on ... zeranoe

Patches should be submitted to the ffmpeg-devel mailing list and not this bug tracker.

Change History (1)

comment:1 by Stefano Sabatini, 13 months ago

Resolution: fixed
Status: newclosed

Should be fixed in 9d140ecaf8076, thanks for the report!

Note: See TracTickets for help on using tickets.