Opened 11 months ago

Last modified 11 months ago

#10427 open defect

Confusion between "luminance" and "luma" in geq documentation

Reported by: Mingye Wang Owned by: Gyan
Priority: minor Component: documentation
Version: git-master Keywords: terminology
Cc: Blocked By:
Blocking: Reproduced by developer: no
Analyzed by developer: no

Description

Summary of the bug: "Luminance" refers to a physical quantity calculated from R, G, and B; "luma" is the video stuff we use calculated from R', G', and B'. The current documentation for vf_geq.c uses the word "luminance", but it clearly deals with the latter.

The term "Chrominance" is acceptable and does not need to be changed.

How to reproduce: Navigate to https://ffmpeg.org/ffmpeg-filters.html#geq.

Change History (4)

comment:1 by Mingye Wang, 11 months ago

About other occurrences of "luminance":

  • JPEG is wrong, but it's grandfathered. Same for VBN.
  • The HDR stuff (luminance_max and _min) get it right, because a physical quantity is really involved.
  • postprocess minLumQuality doc should be changed.
  • VFs histeq, bbox, lut, waveform, pp, doc needs to be changed.

comment:2 by Gyan, 11 months ago

Component: avfilterdocumentation
Owner: set to Gyan
Priority: normalminor
Status: newopen

comment:3 by Gyan, 11 months ago

Will make the change in docs/* except for histeq which only operates upon RGB pixels and not luma (Y')

comment:4 by Gyan, 11 months ago

Pushed a partial set of changes as 285c7f6f6b3740725101e7d5cea94a47e2915298

Note: See TracTickets for help on using tickets.