HEVC encoder settings are not set

[zboubida]

Summary of the bug:
Using a git build on both Linux and Windows (N-59465-g4f8494fe5a-static), when encoding a HEVC video to HEVC, the encoder settings are not set in the encoded file (instead, the original values are copied).
Release 4.4.1 does not exhibit this behaviour.

How to reproduce:
The test.mkv video is HEVC encoded with preset=slow and crf=18. out.mkv will use preset fast and crf=22.
(Using mediainfo here to display the encoder settings)

% ffmpeg -i test.mkv -c:v libx265 -preset fast -x265-params crf=22 out.mkv
ffmpeg version N-59465-g4f8494fe5a-static https://johnvansickle.com/ffmpeg/ Copyright (c) 2000-2021 the FFmpeg developers
[ffmpeg output attached]
% mediainfo --Output='Video;%Encoded_Library_Settings%' test.mkv >test.txt
% mediainfo --Output='Video;%Encoded_Library_Settings%' out.mkv >out.txt
% diff test.txt out.txt && echo $?
0
% mediainfo --Output='Video;%Encoded_Library_Settings%' out.mkv | grep -Eo 'crf=[0-9]+'
crf=18

Same happens in 10bit HEVC. When transcoding from AVC to HEVC, it seems that the encoder settings are added properly.

[zboubida]

ffmpeg output log

[zboubida]

test file

[mkver]

It even forwards an x264 SEI into the first HEVC bitstream if the frames fed to the decoder had them.

[zboubida]

I've just tried with release 5.0 and it seems to be working properly. I can't reproduce the bug anymore so I guess it has been fixed already.

[Balling]

Yeah, this is fixed, of course. In ​https://patchwork.ffmpeg.org/project/ffmpeg/patch/AM7PR03MB66607C2DB65E1AD49D975CF18F7B9@AM7PR03MB6660.eurprd03.prod.outlook.com/ and then 7dfc3cc713ea0dbe7aeedcc2a272a5382a36dbcd.