Opened 3 years ago

Closed 20 months ago

#9345 closed defect (fixed)

Typo in JPEG2000 encoder options

Reported by: Dmitry Sinitsyn Owned by:
Priority: important Component: avcodec
Version: git-master Keywords: j2k
Cc: Blocked By:
Blocking: Reproduced by developer: no
Analyzed by developer: no

Description (last modified by Dmitry Sinitsyn)

Hi,

I've found a typo here:
​https://github.com/FFmpeg/FFmpeg/blob/88b6342c2ba425977aecba2955a256613dddec13/libavcodec/j2kenc.c#L1816-L1817
dwt53 should have value '1', not '0'.

Change History (9)

comment:1 by Dmitry Sinitsyn, 3 years ago

Description: modified (diff)

comment:2 by Dmitry Sinitsyn, 3 years ago

Component: undetermined → avcodec

comment:3 by Balling, 3 years ago

Status: new → open

There is already my patch. ​https://patchwork.ffmpeg.org/project/ffmpeg/patch/20210524092449.11623-1-val.zapod.vz@gmail.com/

Though I really prefer the first version, which is just a two liner.

Last edited 3 years ago by Balling (previous) (diff)

comment:4 by Dmitry Sinitsyn, 3 years ago

Great!
Hopefully it will be applied...
Because, particularly, my patch(different) went even unanswered.

in reply to:  4 ; comment:5 by Balling, 3 years ago

Replying to Dmitry Sinitsyn:

Great!
Hopefully it will be applied...
Because, particularly, my patch(different) went even unanswered.

I cannot see it on patchwork, maybe that is why.
​https://patchwork.ffmpeg.org/project/ffmpeg/list/?submitter=1014&series=&q=&archive=&delegate=&state=*

Version 1, edited 3 years ago by Balling (previous) (next) (diff)

in reply to:  5 comment:6 by Dmitry Sinitsyn, 3 years ago

Replying to Balling:
Yes, that patch, I meant it is for another issue, not for this.

comment:8 by Carl Eugen Hoyos, 2 years ago

Keywords: j2k added; dwt53 removed

comment:9 by Balling, 20 months ago

Resolution: → fixed
Status: open → closed

Finally fixed in f6955b6df4b599ff5604e82987b96957414f8dd5.

Note: See TracTickets for help on using tickets.